Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinentry: excessive derivation closure size #133156

Closed
roberth opened this issue Aug 8, 2021 · 2 comments · Fixed by #133542
Closed

pinentry: excessive derivation closure size #133156

roberth opened this issue Aug 8, 2021 · 2 comments · Fixed by #133542

Comments

@roberth
Copy link
Member

roberth commented Aug 8, 2021

Describe the bug

Pinentry is causing more rebuilds than necessary because it depends on many desktop environments for apparently no good reason.

The unnecessary dependencies also make the package more fragile, as observed in #124753

Steps To Reproduce

Steps to reproduce the behavior:

  1. change qt
  2. build the pinentry-gnome
  3. observe a rebuild

This applies to all combinations of variants.

Expected behavior

Distinct derivations for each variant cause no unnecessary derivation dependencies and therefore no unnecessary rebuilds.

The problem in #124753 is fixed.

Screenshots

Additional context

This is not about the (byte) size of an output closure, but rather about rebuilding too often and depending on too many other packages.

The problem was introduced with cb0adc1

Notify maintainers

@ttuegel @fpletz

Metadata

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
 - pinentry
 - pinentry-curses
 - pinentry-emacs
 - pinentry-gtk2
 - pinentry-qt
 - pinentry-gnome
# a list of nixos modules affected by the problem
module:
@stale
Copy link

stale bot commented Apr 29, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 29, 2022
@roberth roberth removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 30, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 13, 2022
@SuperSandro2000
Copy link
Member

This should be fixed by #277221

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2023
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 15, 2024
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 15, 2024
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 15, 2024
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 15, 2024
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 15, 2024
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jan 29, 2024
SuperSandro2000 pushed a commit to fpletz/nixpkgs that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment