Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional scaling patches should be applied to gnome-control-center #137549

Open
pshirshov opened this issue Sep 12, 2021 · 3 comments
Open

Fractional scaling patches should be applied to gnome-control-center #137549

pshirshov opened this issue Sep 12, 2021 · 3 comments
Labels
0.kind: packaging request 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform

Comments

@pshirshov
Copy link
Contributor

Currently Gnome on Nix doesn't support fractional scaling under X11, which makes life utterly inconvenient.

Just two simple patches can fix that:

It would be good to have them at least as an option.

@pshirshov
Copy link
Contributor Author

Well, seems like just these two patches are not enough. This code falls to the end while it should stop on xrandr branch.

+get_fractional_scaling_key (CcDisplayConfig *self)
+{
+  const char *renderer = cc_display_config_get_renderer (self);
+
+  if (!renderer)
+    g_return_val_if_reached (MUTTER_FEATURE_FRACTIONAL_SCALING_WAYLAND);
+
+  if (g_str_equal (renderer, "xrandr"))
+    return MUTTER_FEATURE_FRACTIONAL_SCALING_X11;
+
+  if (g_str_equal (renderer, "native") || g_str_equal (renderer, "kms"))
+    return MUTTER_FEATURE_FRACTIONAL_SCALING_WAYLAND;
+
+  g_return_val_if_reached (NULL);
+}
+

@pshirshov
Copy link
Contributor Author

pshirshov commented Sep 12, 2021

The P/R is ready and everything works fine: #137556

@veprbl veprbl added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Sep 12, 2021
@stale
Copy link

stale bot commented Apr 25, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform
Projects
None yet
Development

No branches or pull requests

2 participants