Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbcl: add purgeNixReferences option #13997

Closed
wants to merge 1 commit into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 17, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
  • Fits CONTRIBUTING.md.
  • Tested building stuff with the option on; the resulting binaries only need patchelf --set-interpreter to get rid of all references.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @tohl, @7c6f434c and @jwiegley to be potential reviewers

@vcunat vcunat self-assigned this Mar 17, 2016
@vcunat
Copy link
Member Author

vcunat commented Mar 17, 2016

Maybe some of you have a better idea. Otherwise I'm merging in a few days.

@7c6f434c
Copy link
Member

Do I understand correctly that the goal is to make images for non-Nix systems with save-lisp-and-die? Looks reasonable for that use-case…

@vcunat
Copy link
Member Author

vcunat commented Mar 18, 2016

Yes, that's exactly it. Perhaps I should improve the comment to make it more clear?

@7c6f434c
Copy link
Member

Yes, that's exactly it. Perhaps I should improve the comment to make it more clear?

That would definitely be nice both for the comment and for the commit
message.

@vcunat vcunat closed this in 2d72bc1 Mar 18, 2016
@vcunat
Copy link
Member Author

vcunat commented Mar 18, 2016

Pushed, hopefully in a clearer state.

@vcunat vcunat deleted the p/sbcl-references branch March 18, 2016 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants