Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble-1.3.0-git-2015-11-08 doesn't show icons #14084

Closed
ben0x539 opened this issue Mar 20, 2016 · 12 comments
Closed

mumble-1.3.0-git-2015-11-08 doesn't show icons #14084

ben0x539 opened this issue Mar 20, 2016 · 12 comments

Comments

@ben0x539
Copy link
Contributor

Basic info

  • Kernel: Linux vigil 4.4.5 Compile glibc without -fstack-protector. #1-NixOS SMP Wed Mar 9 23:35:58 UTC 2016 x86_64 GNU/Linux
  • System: 16.09pre78848.9549257 (Flounder)
  • Nix version: nix-env (Nix) 1.11.2
  • Nixpkgs version: "16.09pre78848.9549257"

Describe your issue here

Most icons, for example in the toolbar, the tray area, and beside items in the various tree views in the GUI, are missing in mumble_git.

nix-env -iA kde5.breeze-icons seems to be a workaround, even though afaict most of those icons are mumble-specific and not part of breeze.

Expected result

Actual result

Steps to reproduce

nix-env -iA nixos.mumble_git, without having installed nixos.kde5.breeze-icons or presumably other parts of of kde that pull that in.

@codyopel
Copy link
Member

@ben0x539
Mumble bundles all of its own icons, the issue is that it fails to load svg icons. I looked into this at one point and I believe it may be an issue with qt5 qtsvg, but I could be wrong.

cc @ttuegel

@abbradar
Copy link
Member

I've seen this issue from time to time and still don't have any clue what's going on -- it fixes itself magically after a while.

@ttuegel
Copy link
Member

ttuegel commented Mar 21, 2016

I presume this pertains to the Qt 5 version of mumble. The package provides SVG icons, so it needs qtsvg at runtime; that is why installing breeze-icons may fix this issue. There are three things the maintainers (@viric @jgeerds @wkennington) need to do to fix this issue:

  1. Call the package with qt5.callPackage.
  2. Include qtsvg in buildInputs.
  3. Wrap the resulting executable(s) with wrapQtProgram after installPhase.

@pstn
Copy link
Contributor

pstn commented Apr 22, 2016

I also had that problem with the default mumble package and it got fixed after I installed kde5.breeze-icons.

@garbas
Copy link
Member

garbas commented May 24, 2016

@viric @jgeerds @wkennington pinging maintainers to fix the issue as described by @ttuegel

@garbas
Copy link
Member

garbas commented May 24, 2016

anybody else @pstn @ben0x539 @abbradar @codyopel also welcome to send a PR :)

@abbradar
Copy link
Member

I had this issue before but I can't reproduce it now. I'm using Qt 4 version of Mumble.

@RonnyPfannschmidt
Copy link
Contributor

i can reproduce on mumble_git

@abbradar
Copy link
Member

@RonnyPfannschmidt can you try abbradar@5bf8b49? Also, check if you can reproduce it with mumble (I still can't).

@RonnyPfannschmidt
Copy link
Contributor

@abbradar building now, i noticed that also the buildinput for python is missing (and this causes nonfatal errors)

@RonnyPfannschmidt
Copy link
Contributor

@abbradar the patch works

@abbradar
Copy link
Member

Thanks for testing! I've also patched Python scripts.

abbradar added a commit that referenced this issue Mar 31, 2017
Fixes #14084.

(cherry picked from commit d8c47a2)
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
Fixes NixOS#14084.

(cherry picked from commit d8c47a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants