libint: 2.6.0 -> 2.7.1 #142835
Merged
libint: 2.6.0 -> 2.7.1 #142835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskowa
reviewed
Oct 25, 2021
libint: angular momentum back to 7,5,4
SuperSandro2000
requested changes
Oct 25, 2021
| }; | ||
|
|
||
| patches = [ ./fix-paths.patch ]; | ||
| # Hardcoded /bin/rm instead of a simple rm | ||
| patches = [ ./autotools.patch ]; |
There was a problem hiding this comment.
Lets use substituteInPlace so that we don't need to maintain this patch.
There was a problem hiding this comment.
Isn't the argument usually the opposite, and patches are the preferred solutions instead?
There was a problem hiding this comment.
patches are preferred for complex changes which take complex sed commands but here we are just replacing /bin/rm with rm which can be done with a simple command.
There was a problem hiding this comment.
Have replaced it with substituteInPlace on the relevant files, but now one still needs to maintain the list of files, to which this applies. I would rather not apply it to every single file by default.
|
@GrahamcOfBorg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates to the latest stable release of libint.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)