-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable FFmpeg expression, fdk-aac library, license fixes #1461
Conversation
It looks good, thanks! |
add configurable FFmpeg expression, fdk-aac library, license fixes
Actually, I planned to make a configurable ffmpeg/libav switch, so this will be a very nice base. Also for supporting multiple versions inside one expression. When I get to it... there are higher-priority issues right now (e.g. stdenv-updates). |
Hm, we already have 5 variants of ffmpeg in Nixpkgs, do we really want another one? In particular, why do we need both ffmpeg/2.x.nix and ffmpeg/configurable.nix, given that they both build version 2.1.1? |
I'd say 2.x.nix should use configurable one. |
I think all should use one configurable expression (a slight modification of this one, for example). |
(So far the files only differed in hash and version AFAIK. And maybe some older versions aren't really needed anymore.) |
I recently upgraded every (minor) version and checked each package in |
@bluescreen303: even if considering updating the packages (that don't support newer versions)? |
I looked at this and upgraded some. |
These commits do several things:
ffmpeg_configurable
, a configurable expression for FFmpeg styled aftervim_configurable
. Otherwise, it's difficult to configure an FFmpeg expression for users who want the command line tool in their environment.fdk-aac
library, a high-quality AAC codec implementation from Android.ffmpeg_2
andffmpeg_configurable
to use thefdk-aac
library. This is disabled by default because:fdk-aac
orfaac
are enabled, in which case it is non-free and unredistributable.