VMware guest additions support for aarch64 #147650

samuela · 2021-11-28T03:43:14Z

Describe the bug

The virtualisation.vmware.guest.enable = true option does not work on aarch64-linux due to

nixpkgs/nixos/modules/virtualisation/vmware-guest.nix

Lines 25 to 28 in 5d6a70c

    
           assertions = [ { 
        
             assertion = pkgs.stdenv.hostPlatform.isx86; 
        
             message = "VMWare guest is not currently supported on ${pkgs.stdenv.hostPlatform.system}"; 
        
           } ];

See also https://discourse.nixos.org/t/vmware-guest-tools-on-aarch64-linux/16248.

It seems that the current issue is that xorg.xf86inputvmmouse does not build on aarch64-linux.

Steps To Reproduce

Steps to reproduce the behavior:

Run NixOS on aarch64-linux.
Set the virtualisation.vmware.guest.enable = true option.
Observe the failure.

Expected behavior

aarch64-linux support

Screenshots

n/a

Additional context

See also https://discourse.nixos.org/t/vmware-guest-tools-on-aarch64-linux/16248.

Notify maintainers

@joamaki @anoever @kjeremy

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: aarch64-linux
- host os: Linux 5.10.81, NixOS, 21.05.4361.43bbfd4994c (Okapi)
- multi-user?: yes
- sandbox: yes
- version: nix-env (Nix) 2.3.16
- nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: xorg.xf86inputvmmouse
# a list of nixos modules affected by the problem
module: virtualisation.vmware.guest

The text was updated successfully, but these errors were encountered:

nixos-discourse · 2021-11-28T03:47:25Z

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/vmware-guest-tools-on-aarch64-linux/16248/7

evanrelf · 2022-01-12T07:21:28Z

It looks like xorg.xf86inputvmmouse is only pulled in when virtualisation.vmware.guest.headless = false:

nixpkgs/nixos/modules/virtualisation/vmware-guest.nix

Lines 65 to 81 in 386234e

    
               services.xserver = mkIf (!cfg.headless) { 
        
                 videoDrivers = mkOverride 50 [ "vmware" ]; 
        
                 modules = [ xf86inputvmmouse ]; 
        
                 config = '' 
        
                     Section "InputClass" 
        
                       Identifier "VMMouse" 
        
                       MatchDevicePath "/dev/input/event*" 
        
                       MatchProduct "ImPS/2 Generic Wheel Mouse" 
        
                       Driver "vmmouse" 
        
                     EndSection 
        
                   ''; 
        
                 displayManager.sessionCommands = '' 
        
                     ${open-vm-tools}/bin/vmware-user-suid-wrapper 
        
                   ''; 
        
               };

Maybe the assertion could be relaxed a bit?

     assertions = [ {
-      assertion = pkgs.stdenv.hostPlatform.isx86;
+      assertion = pkgs.stdenv.hostPlatform.isx86 && !cfg.headless;
       message = "VMWare guest is not currently supported on ${pkgs.stdenv.hostPlatform.system}";
    } ];

d4g · 2022-09-29T08:54:39Z

Bump. Please change this so that we can at least use the guest tools in headless mode as mentioned here:

It looks like xorg.xf86inputvmmouse is only pulled in when virtualisation.vmware.guest.headless = false:

nixpkgs/nixos/modules/virtualisation/vmware-guest.nix

Lines 65 to 81 in 386234e

services.xserver = mkIf (!cfg.headless) {

videoDrivers = mkOverride 50 [ "vmware" ];

modules = [ xf86inputvmmouse ];

config = ''

Section "InputClass"

Identifier "VMMouse"

MatchDevicePath "/dev/input/event*"

MatchProduct "ImPS/2 Generic Wheel Mouse"

Driver "vmmouse"

EndSection

'';

displayManager.sessionCommands = ''

${open-vm-tools}/bin/vmware-user-suid-wrapper

'';

};

Maybe the assertion could be relaxed a bit?
     assertions = [ {
-      assertion = pkgs.stdenv.hostPlatform.isx86;
+      assertion = pkgs.stdenv.hostPlatform.isx86 && !cfg.headless;
       message = "VMWare guest is not currently supported on ${pkgs.stdenv.hostPlatform.system}";
    } ];

kjeremy · 2022-09-29T14:23:10Z

@d4g Can you submit a PR and change the assertion message? This makes sense.

addict3d · 2022-10-05T17:01:56Z

@samuela or @d4g could you give #194621 a try?

addict3d · 2022-10-05T17:06:58Z

Can you submit a PR and change the assertion message? This makes sense.

@kjeremy Any suggestions on how to update the assertion message?

Am not sure if it should also be conditional.

d4g · 2022-10-05T17:54:22Z

Can you tell me how to single pick this PR in my configuration? Define an override?

addict3d · 2022-10-06T03:06:41Z

Can you tell me how to single pick this PR in my configuration?

Yes. There are multiple ways to do this. So finding the simplest or easiest way will depend on your current setup.

How do you define/import nixpkgs in your configuration?

Define an override?

That'd be one way to do it. AFAIK you'd need to add the vmware-guest.nix file to disabledModules (see "66.7. Replace Modules"), and bind a new nixpkgs reference to my branch, where you'd import that module from.

abhillman · 2022-10-10T04:59:10Z

AFAICT this is also a blocker for creating a graphical ISO for aarch64:

bash-4.4# nix-build -A config.system.build.isoImage -I nixos-config=modules/installer/cd-dvd/installation-cd-graphical-gnome.nix default.nix
error:
       Failed assertions:
       - VMWare guest is not currently supported on aarch64-linux
(use '--show-trace' to show detailed location information)
bash-4.4# uname -a
Linux 14c6bb46a97a 5.10.124-linuxkit #1 SMP PREEMPT Thu Jun 30 08:18:26 UTC 2022 aarch64 GNU/Linux

abhillman · 2022-10-10T05:06:28Z

Seems to work on aarch64 for me:

[nix-shell:/nixpkgs/nixos]# git diff
diff --git a/nixos/modules/virtualisation/vmware-guest.nix b/nixos/modules/virtualisation/vmware-guest.nix
index 3b4d484f..c6ee7a40 100644
--- a/nixos/modules/virtualisation/vmware-guest.nix
+++ b/nixos/modules/virtualisation/vmware-guest.nix
@@ -23,7 +23,7 @@ in
 
   config = mkIf cfg.enable {
     assertions = [ {
-      assertion = pkgs.stdenv.hostPlatform.isx86;
+      assertion = pkgs.stdenv.hostPlatform.isx86 || pkgs.stdenv.hostPlatform.isAarch64;
       message = "VMWare guest is not currently supported on ${pkgs.stdenv.hostPlatform.system}";
     } ];

NixOS#147650

d4g · 2022-10-12T11:40:34Z

Does not seem to work for me:

/etc/nixos/configuration.nix:

Rebuild:

Assertion is in vmware.nix:

(Sorry for screenshots, but copy/paste does not work yet ... as it requires the vmware guest tools ... )

bestlem · 2023-01-08T04:36:09Z

Any progress - I am a begginer in nixOS.

So the way to learn is setup a VM
But then I hit this.

What are the exact steps to use this PR?

This is not just a mouse issue as the previous comment not it stops cut and paste. It also shops the use of shared folders so a fix is needed for the headless case as well.

ThorbenJ · 2023-07-03T09:55:24Z

I would love to have vmware guest on aarch64 too. I'm running VMWare Fusion on my M1 macbook.

I tried the above, of disabling the vmware-guest.nix and adding my own with the assert modified to accept Aarch64. However it not building x11 mouse is one issue, but even with headless = true it still fails; in this case vmw_vpscsi fails in the kernel build:

kjeremy · 2023-07-07T18:58:08Z

@ThorbenJ that's a module that comes with the kernel and not vmware. It looks like it's not supported under non-x86 architectures: https://cateee.net/lkddb/web-lkddb/VMWARE_PVSCSI.html so we should remove it from the module if not on x86

kjeremy · 2023-07-07T19:43:03Z

@ThorbenJ can you test #242126? I don't have aarch64 but this might work.

ThorbenJ · 2023-07-14T09:04:40Z

Magic. It built successfully and as soon as nixos-rebuild switch completed my X desktop resized to match my monitor (automatically).

I just used my own local vmware-guest.nix (disabling the system one), in which I made the two changes that are in kjeremy's PR ^

Thank you.

samuela added the 0.kind: bug label Nov 28, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 31, 2022

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 29, 2022

addict3d mentioned this issue Oct 5, 2022

nixos/vmware-guest: refactor platform restriction #194621

Closed

abhillman added a commit to abhillman/nixpkgs that referenced this issue Oct 10, 2022

Enable VMWare Guest Support for aarch64

a6380db

NixOS#147650

abhillman mentioned this issue Oct 10, 2022

Enable VMWare Guest Support for aarch64 #195321

Closed

13 tasks

kjeremy mentioned this issue Jul 7, 2023

vmware-guest module: work under aarch64 #242126

Merged

12 tasks

SuperSandro2000 closed this as completed in #242126 Jul 14, 2023

thomasdziedzic-calmwave mentioned this issue Oct 4, 2023

Unable to install vmware guest additions on aarch64 #258983

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VMware guest additions support for aarch64 #147650

VMware guest additions support for aarch64 #147650

samuela commented Nov 28, 2021 •

edited

nixos-discourse commented Nov 28, 2021

evanrelf commented Jan 12, 2022 •

edited

d4g commented Sep 29, 2022

kjeremy commented Sep 29, 2022

addict3d commented Oct 5, 2022

addict3d commented Oct 5, 2022

d4g commented Oct 5, 2022

addict3d commented Oct 6, 2022

abhillman commented Oct 10, 2022

abhillman commented Oct 10, 2022

d4g commented Oct 12, 2022 •

edited

bestlem commented Jan 8, 2023 •

edited

ThorbenJ commented Jul 3, 2023 •

edited

kjeremy commented Jul 7, 2023 •

edited

kjeremy commented Jul 7, 2023

ThorbenJ commented Jul 14, 2023

VMware guest additions support for aarch64 #147650

VMware guest additions support for aarch64 #147650

Comments

samuela commented Nov 28, 2021 • edited

Describe the bug

Steps To Reproduce

Expected behavior

Screenshots

Additional context

Notify maintainers

Metadata

nixos-discourse commented Nov 28, 2021

evanrelf commented Jan 12, 2022 • edited

d4g commented Sep 29, 2022

kjeremy commented Sep 29, 2022

addict3d commented Oct 5, 2022

addict3d commented Oct 5, 2022

d4g commented Oct 5, 2022

addict3d commented Oct 6, 2022

abhillman commented Oct 10, 2022

abhillman commented Oct 10, 2022

d4g commented Oct 12, 2022 • edited

bestlem commented Jan 8, 2023 • edited

ThorbenJ commented Jul 3, 2023 • edited

kjeremy commented Jul 7, 2023 • edited

kjeremy commented Jul 7, 2023

ThorbenJ commented Jul 14, 2023

samuela commented Nov 28, 2021 •

edited

evanrelf commented Jan 12, 2022 •

edited

d4g commented Oct 12, 2022 •

edited

bestlem commented Jan 8, 2023 •

edited

ThorbenJ commented Jul 3, 2023 •

edited

kjeremy commented Jul 7, 2023 •

edited