autorandr: install zsh completions #148678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autorandr includes functional zsh completions upstream they just lack a make target to install the relevant file. For some consistency use the direct file for both zsh and bash rather than just zsh. Note this changes the resulting bash completion filename from just 'autorandr' to 'autorandr.bash' See phillipberndt/autorandr#197
anund
force-pushed
the
fix_autorandr_zsh_completions
branch
from
54982ea
to
bdda2cc
Compare
anund
commented
Dec 5, 2021
| @@ -23,7 +26,12 @@ stdenv.mkDerivation rec { | |||
| runHook preInstall | |||
| make install TARGETS='autorandr' PREFIX=$out | |||
|
|
|||
| make install TARGETS='bash_completion' DESTDIR=$out/share/bash-completion/completions | |||
There was a problem hiding this comment.
I'm not sure if this is doing what's intended. Looking at the makefile I think this works by generating a path like ~$out/share/bash-completion/completions//autorandr
From the makefile https://github.com/phillipberndt/autorandr/blob/1.11/Makefile#L55
install -D -m 644 contrib/bash_completion/autorandr ${DESTDIR}/${BASH_COMPLETIONS_DIR}/autorandr
1 task
|
Successfully created backport PR #148688 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autorandr includes functional zsh completions upstream they just lack
a make target to install the relevant file. For some consistency use the
direct file for both zsh and bash rather than just zsh. Note this
changes the resulting bash completion filename from just 'autorandr' to
'autorandr.bash'
See phillipberndt/autorandr#197
Motivation for this change
Add working auto completion for
autorandrto zsh.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes