Remove nvidia-cg-toolkit as input for retroarch. #15739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @edwtjo, @MP2E and @jraygauthier to be potential reviewers |
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
from
e79959a
to
780c66c
Compare
|
Makes sense to me. What remains to be done? |
|
I'm trying to get it to work on Darwin still but it might be more difficult than I was expecting. |
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
from
780c66c
to
39b3aa3
Compare
matthewbauer
changed the title
|
This should be ready if all tests pass. |
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
from
39b3aa3
to
66c3c9e
Compare
|
This should be ready to merge. |
| homepage = http://libretro.org/; | ||
| description = "Multi-platform emulator frontend for libretro cores"; | ||
| license = licenses.gpl3; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| maintainers = with maintainers; [ MP2E edwtjo ]; | ||
| platforms = with platforms; [ linux darwin ]; |
There was a problem hiding this comment.
Both linux and darwin are lists, so this should be linux ++ darwin, strictly speaking.
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
from
66c3c9e
to
57fa59f
Compare
|
@joachifm I'm just going to put it as "platforms.all" because there's no reason it shouldn't work on other platforms but I've only got it tested on Linux and Darwin. |
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
10 times, most recently
from
2acf25d
to
3eee4df
Compare
also: remove nvidia-cg-toolkit as input for retroarch. see NixOS#15707 darwin is also building but you have to trick it into thinking it's a desktop app for the GUI to load platforms is set to "platforms.all".
matthewbauer
force-pushed
the
retroarch-disable-nvidia
branch
from
3eee4df
to
e37bb98
Compare
|
Travis is failing because of space issues. Should still be okay to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)see #15707