Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stan: fix build by not running tests with nonexistent /usr/bin/python #15968

Merged
merged 1 commit into from
Jun 26, 2016

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jun 3, 2016

Now stan can build on NixOS ...

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @davidar to be a potential reviewer

@bcdarwin
Copy link
Member Author

bcdarwin commented Jun 3, 2016

Never mind, there still seem to be some dependency issues ...

@bcdarwin bcdarwin closed this Jun 3, 2016
@bcdarwin bcdarwin reopened this Jun 6, 2016
@bcdarwin
Copy link
Member Author

bcdarwin commented Jun 6, 2016

The Travis build is failing because of disk space issues.

As I mentioned, there are still some minor issues. The author defined a stan script to work around some of cmdstan's weird directory conventions, but this calls make which in general isn't installed. The test suite still passes on my machine, though, so I'll leave this for another PR.

@fpletz fpletz merged commit 07cfc15 into NixOS:master Jun 26, 2016
@bcdarwin bcdarwin deleted the fix-cmdstan branch June 27, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants