igv: init at 2.3.77 #16505
Merged
igv: init at 2.3.77 #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebasing. |
|
@mimadrid why close? You can simply rebase ontop of master and force push the branch. |
|
Github closed it because I deleted the branch by accident D: although I repushed it Github doesn't reattach it. |
|
With the pull request open Github reattached it now. |
| sha256 = "9d8c622649f9f02026e92fa44006bb57e897baad4359c8708ca9cdbb71f94bb5"; | ||
| }; | ||
|
|
||
| buildInputs = [ unzip makeWrapper jre ]; |
There was a problem hiding this comment.
makeWrapper looks to be unused?
|
@joachifm thanks for being so patient. Fixed. |
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://www.broadinstitute.org/igv/"; | ||
| description = "A high-performance visualization tool for interactive exploration of large, integrated genomic datasets."; |
There was a problem hiding this comment.
Please make a description a little bit shorter and remove dot at the end.
|
Thanks @jagajaga, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add Integrative Genomics Viewer (IGV) to NixOS
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)