Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uzbl: Fix wrong python site-package path #16740

Closed
wants to merge 3 commits into from

Conversation

HappyEnt
Copy link
Contributor

@HappyEnt HappyEnt commented Jul 5, 2016

Motivation for this change

Uzbl fails to build because of wrong python site-package path ('python3.5' expected vs 'python3.4' as it is now). An alternative fix would be specifying the python version to be used as 3.4.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@HappyEnte, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dgonyeo, @7c6f434c and @lethalman to be potential reviewers

@FRidh
Copy link
Member

FRidh commented Jul 6, 2016

please use $out/python.sitePackages instead.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/3.5/default.nix#L112

@FRidh
Copy link
Member

FRidh commented Jul 6, 2016

in this case that would be python3.sitePackages

@joachifm
Copy link
Contributor

This looks ready to me, is it? @HappyEnte please squash the commits.

@FRidh
Copy link
Member

FRidh commented Jul 19, 2016

just having a closer look at this package, and there's more wrong with it. The expression mixes python 2 and 3. Python packages are added as buildInputs, which is wrong, since it will need pygtk during runtime.

@FRidh
Copy link
Member

FRidh commented Jul 19, 2016

Fixed with bae6ad8

@FRidh FRidh closed this Jul 19, 2016
FRidh added a commit that referenced this pull request Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants