Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutt: 1.6.0 -> 1.6.2 #16805

Merged
merged 1 commit into from
Jul 12, 2016
Merged

mutt: 1.6.0 -> 1.6.2 #16805

merged 1 commit into from
Jul 12, 2016

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 9, 2016

Motivation for this change

See #16772

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I have taken the patches from the mutt-sidebar AUR package. I have tried both sidebar and trash folder: they seem to work however I'm not personally using these features and I have not configured them so I can't be 100% sure.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @the-kenny and @kragniz to be potential reviewers

@joachifm joachifm merged commit 9903923 into NixOS:master Jul 12, 2016
@joachifm
Copy link
Contributor

LGTM. Thank you

@joachifm
Copy link
Contributor

Oh, I can't believe I failed to notice the huge patches ... @rnhmjoj would you mind replacing those with fetchpatch or similar? I would do it myself, but I'm not sure exactly where those patches come from.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 16, 2016

Sorry, I don't really have time now. The patches are here btw.

@joachifm
Copy link
Contributor

@rnhmjoj no worries, I'll look into fixing it, thank you for the pointer

@joachifm
Copy link
Contributor

Fixed in a317a15

@joachifm joachifm mentioned this pull request Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants