Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfsdump fails to build against latest xfsprogs #177779

Closed
lunik1 opened this issue Jun 15, 2022 · 0 comments · Fixed by #179549
Closed

xfsdump fails to build against latest xfsprogs #177779

lunik1 opened this issue Jun 15, 2022 · 0 comments · Fixed by #179549

Comments

@lunik1
Copy link
Contributor

lunik1 commented Jun 15, 2022

Steps To Reproduce

Steps to reproduce the behavior:

  1. build xfsdump

Build log

[...]
hsmapi.c:874:17: warning: 'attr_removef' is deprecated: Use fremovexattr instead [-Wdeprecated-declarations]
  874 |                 rv = attr_removef(fd, DMF_ATTR_NAME, ATTR_ROOT);
      |                 ^~
In file included from hsmapi.c:28:
/nix/store/v0hlv9dac70c94izzmcxdmsfl0grnhr7-attr-2.5.1-dev/include/attr/attributes.h:155:12: note: declared here
  155 | extern int attr_removef (int __fd, const char *__attrname, int __flags)
      |            ^~~~~~~~~~~~
    [CC]     lock.o
    [CC]     main.o
    [CC]     mlog.o
    [CC]     openutil.o
    [CC]     path.o
    [CC]     qlock.o
    [CC]     ring.o
    [CC]     stream.o
    [CC]     timeutil.o
    [CC]     util.o
    [CC]     inv_api.o
    [CC]     inv_core.o
    [CC]     inv_files.o
    [CC]     inv_fstab.o
    [CC]     inv_idx.o
    [CC]     inv_mgr.o
    [CC]     inv_stobj.o
    [CC]     bag.o
    [CC]     content.o
content.c: In function 'restore_complete_reg':
content.c:7727:29: error: storage size of 'fssetdm' isn't known
 7727 |                 fsdmidata_t fssetdm;
      |                             ^~~~~~~
content.c:7734:34: error: 'XFS_IOC_FSSETDM' undeclared (first use in this function); did you mean 'XFS_IOC_FSSETXATTR'?
 7734 |                 rval = ioctl(fd, XFS_IOC_FSSETDM, (void *)&fssetdm);
      |                                  ^~~~~~~~~~~~~~~
      |                                  XFS_IOC_FSSETXATTR
content.c:7734:34: note: each undeclared identifier is reported only once for each function it appears in
content.c:7727:29: warning: unused variable 'fssetdm' [-Wunused-variable]
 7727 |                 fsdmidata_t fssetdm;
      |                             ^~~~~~~
content.c: In function 'restore_symlink':
content.c:8061:29: error: storage size of 'fssetdm' isn't known
 8061 |                 fsdmidata_t fssetdm;
      |                             ^~~~~~~
content.c:8061:29: warning: unused variable 'fssetdm' [-Wunused-variable]
content.c: In function 'setextattr':
content.c:8867:9: warning: 'attr_set' is deprecated: Use setxattr or lsetxattr instead [-Wdeprecated-declarations]
 8867 |         rval = attr_set(path,
      |         ^~~~
In file included from content.c:27:
/nix/store/v0hlv9dac70c94izzmcxdmsfl0grnhr7-attr-2.5.1-dev/include/attr/attributes.h:139:12: note: declared here
  139 | extern int attr_set (const char *__path, const char *__attrname,
      |            ^~~~~~~~
content.c: In function 'Media_mfile_next':
content.c:4797:33: warning: ignoring return value of 'system' declared with attribute 'warn_unused_result' [-Wunused-result]
 4797 |                                 system(media_change_alert_program);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
content.c: In function 'restore_extent':
content.c:8625:49: warning: ignoring return value of 'ftruncate' declared with attribute 'warn_unused_result' [-Wunused-result]
 8625 |                                                 ftruncate(fd, bstatp->bs_size);
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [../include/buildrules:47: content.o] Error 1
make[1]: *** [include/buildrules:23: restore] Error 2
make: *** [Makefile:53: default] Error 2

Additional context

Introduced in #176150 - affects unstable.

Upstream issue, I am consulting with them and trying to put together a patch.

Notify maintainers

it me

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant