Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vapoursynth #18029

Merged
merged 4 commits into from
Sep 8, 2016
Merged

Vapoursynth #18029

merged 4 commits into from
Sep 8, 2016

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 27, 2016

Motivation for this change

Add packages for vapoursynth and other dependencies and enable vapoursynth scripting support in mpv. The true motivation is having 24Hz -> 60Hz motion frame interpolation.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @AndersonTorres, @codyopel and @fpletz to be potential reviewers

@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

cc @Fuuzetsu

buildInputs = [ autoreconfHook ];

meta = with stdenv.lib; {
description = "Scaling, colorspace conversion and dithering library.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove trailing punctuation from meta.description

@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

Looks like zimg fails on darwin

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 4, 2016

Yep, it was reported upstream: sekrit-twc/zimg#52
What do I do?

@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

You could simply disable the darwin build for zimg for the time being. Seeing as mpv is only built on linux currently it shouldn't matter.

Will adding vapoursynth support greatly enlarge the mpv closure?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 4, 2016

Quite, It's 470MB larger. Should I disable vapoursynth by default?

@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

Ouch, that's a bit much for my tastes. Is it something most people would want? If not, perhaps it is best to leave it disabled by default.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 4, 2016

Well, I think most people doesn't even know it exists. It's not enabled in other distros by default or it has separate package so I'll disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants