-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vapoursynth #18029
Vapoursynth #18029
Conversation
@rnhmjoj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @AndersonTorres, @codyopel and @fpletz to be potential reviewers |
cc @Fuuzetsu |
buildInputs = [ autoreconfHook ]; | ||
|
||
meta = with stdenv.lib; { | ||
description = "Scaling, colorspace conversion and dithering library."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove trailing punctuation from meta.description
Looks like |
Yep, it was reported upstream: sekrit-twc/zimg#52 |
You could simply disable the darwin build for zimg for the time being. Seeing as mpv is only built on linux currently it shouldn't matter. Will adding vapoursynth support greatly enlarge the mpv closure? |
Quite, It's 470MB larger. Should I disable vapoursynth by default? |
Ouch, that's a bit much for my tastes. Is it something most people would want? If not, perhaps it is best to leave it disabled by default. |
Well, I think most people doesn't even know it exists. It's not enabled in other distros by default or it has separate package so I'll disable it. |
Motivation for this change
Add packages for vapoursynth and other dependencies and enable vapoursynth scripting support in mpv. The true motivation is having 24Hz -> 60Hz motion frame interpolation.
Things done
(nix.useChroot on NixOS,
or option
build-use-chroot
innix.conf
on non-NixOS)