tomcat5: remove (EOL) #18341
Merged
tomcat5: remove (EOL) #18341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source is not available anymore.
|
@groxxda, thanks for your PR! By analyzing the annotation information on this pull request, we identified @eelcovisser and @edolstra to be potential reviewers |
|
Alternatively, #18345 actually fixes it. |
|
@chris-martin : https://tomcat.apache.org/security-5.html If there really is a need for tomcat 5, we should update to 5.5.36 and take the 10 years worth of security updates. Please note: even that version hasn't been fixed in nearly 4 years. |
7 tasks
|
The tomcat5 package doesn't even build, so I'm going to go ahead and agree with you, let's just ditch it. |
fpletz
pushed a commit
that referenced
this pull request
Sep 6, 2016
Source is not available anymore. (cherry picked from commit 36e8df1)
fpletz
pushed a commit
that referenced
this pull request
Sep 6, 2016
Source is not available anymore. (cherry picked from commit 36e8df1)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Source is not available anymore. (cherry picked from commit 36e8df1)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Source is not available anymore. (cherry picked from commit 36e8df1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Please also backport to 16.09
"Fixes" #18336
The source for 5.0.27 is not available anymore.We could update to 5.0.30 (2004-11-24) or 5.5.36 (2012-10-09) but I don't think it's worth the effort.Archive url: http://archive.apache.org/dist/tomcat/tomcat-5/
EOL announcement: https://tomcat.apache.org/tomcat-55-eol.html
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)