Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.4.0 -> 1.5.1 #18468

Merged
merged 1 commit into from
Sep 13, 2016
Merged

vscode: 1.4.0 -> 1.5.1 #18468

merged 1 commit into from
Sep 13, 2016

Conversation

uralbash
Copy link
Member

@uralbash uralbash commented Sep 9, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@uralbash, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Ptival, @mucaho and @jgillich to be potential reviewers

@Ptival
Copy link
Contributor

Ptival commented Sep 12, 2016

👍
Looks good to me!

@fpletz fpletz merged commit 8553883 into NixOS:master Sep 13, 2016
wizeman pushed a commit to wizeman/nixpkgs that referenced this pull request Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants