subtitleeditor: 0.52.1 -> 0.53.0 #18787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
reviewed
Sep 21, 2016
| @@ -1,22 +1,25 @@ | |||
| { stdenv, fetchurl, pkgconfig, autoconf, automake114x, intltool, | |||
| { stdenv, fetchurl, pkgconfig, autoconf, automake114x, intltool, file, | |||
| enableParallelBuilding = true; | ||
|
|
||
| doCheck = true; |
There was a problem hiding this comment.
Because there is a failure when making check in the po subdirectory:
[...]
Making check in po
make[1]: Entering directory '/tmp/nix-build-subtitle-editor-0.53.0.drv-18/subtitleeditor-0.53.0/po'
INTLTOOL_EXTRACT="/nix/store/cl7za9xhla6nax0yhg37q10c12pw30wj-intltool-0.51.0/bin/intltool-extract" XGETTEXT="/nix/store/mlqqfj2b2y42p2fnj05m5706b7qg3vab-gettext-0.19.8/bin/xgettext" srcdir=. /nix/store/cl7za9xhla6nax0yhg37q10c12pw30wj-intltool-0.51.0/bin/intltool-update --gettext-package subtitleeditor --pot
rm -f missing notexist
srcdir=. /nix/store/cl7za9xhla6nax0yhg37q10c12pw30wj-intltool-0.51.0/bin/intltool-update -m
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?PACKAGE_NAME}?/ at /nix/store/cl7za9xhla6nax0yhg37q10c12pw30wj-intltool-0.51.0/bin/intltool-update line 1071, <CONF> line 417.
The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.
plugins/actions/template/dialog-template-save-as.ui
plugins/actions/template/template.cc
If some of these files are left out on purpose then please add them to
POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list
of left out files has been written in the current directory.
if [ -r missing -o -r notexist ]; then \
exit 1; \
fi
make[1]: *** [Makefile:495: check] Error 1
make[1]: Leaving directory '/tmp/nix-build-subtitle-editor-0.53.0.drv-18/subtitleeditor-0.53.0/po'
make: *** [Makefile:477: check-recursive] Error 1
[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)