crafty: 23.4 -> 25.0.1 (and: fix the build, remove obsolete options)

[samuelrivas]

Motivation for this change

Crafty doesn't build, among other reasons because it cannot download part of the sources

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

• Download URLs changed to www.craftychess.com
• crafty 23.4 doesn't quite build, updated to latest
• Modify the wrapping script so that the books are in the user's home (so that
  they can be easily modified and also so that crafty can learn)
• End game table bases are no longer available (should be built) removed from
  now
• Platform specific targets changed, I can only test linux, so removed darwin
  for now
• The enormous pgn is no longer available, removed

update urls

move the books to HOME

So that learning works and we can modify books to control openings

remove leftovers

Delete unused parts

I have no idea how to build for ios, so I fixed linux build only (ios build was
broken anyway, so I removed it)

I couldn't find the new end game table bases, so I removed them for now.

[mention-bot]

@samuelrivas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jwiegley, @edolstra and @bjornfor to be potential reviewers.

[samuelrivas]

Solving the conflicts, will reopen when is done

[Mic92]

so the assumption that this line build on both platforms?

[samuelrivas]

No, I don't know how to build this for Mac. make darwin, however, doesn't
seem to exist any longer so the only sure thing is that it won't build for
it if we keep it.

If someone can check how to build this for mac I will be glad to extend the
patch

On 5 October 2016 at 13:42, Jörg Thalheim notifications@github.com wrote:

@Mic92 commented on this pull request.

In pkgs/games/crafty/default.nix
#19229 (review):

buildInputs = [ unzip ];

• buildPhase =
• if stdenv.isDarwin
• then "make darwin"
• else if stdenv.isLinux

•       then "make linux-amd64"
  

•       else "make";
  

• unpackPhase = ''
• mkdir "craftysrc"
• unzip $src -d craftysrc
• gunzip -c $startPgn > "craftysrc/start.pgn"
• '';

• buildPhase = ''
• cd craftysrc
• make unix-gcc

so the assumption that this line build on both platforms?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#19229 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGktwhzq2fgu2ARgtYsRq0UqMvgAUxaks5qw40LgaJpZM4KN-k6
.

Samuel

[Mic92]

let's test with hydra until I get my osx vm up and running.

[samuelrivas]

cool, let me know if you find problems!

On 6 October 2016 at 10:04, Jörg Thalheim notifications@github.com wrote:

let's test with hydra until I get my osx vm up and running.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#19229 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGkt1SmJtQM3hqYud41nZa34ZvxSDniks5qxKubgaJpZM4KN-k6
.

Samuel

[samuelrivas]

I can't find crafty in hydra? Where should I look for it?