fix metacoq builds for coq >= 8.16 in dev mode, adds 1.1 release for coq 8.16 #192437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoDralliam
force-pushed
the
metacoq-fix-dev
branch
from
a56c248
to
83a6a18
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
@Zimmi48, @CohenCyril, @vbgl would one of you consider reviewing this PR ? |
CohenCyril
reviewed
Sep 27, 2022
Comment on lines
24
to
25
| "1.1-8.14".sha256 = ""; | ||
| "1.1-8.15".sha256 = ""; |
There was a problem hiding this comment.
I guess you need to update this
vbgl
reviewed
Sep 27, 2022
Comment on lines
24
to
25
| "1.1-8.14".sha256 = ""; | ||
| "1.1-8.15".sha256 = ""; |
There was a problem hiding this comment.
Suggested change
| "1.1-8.14".sha256 = ""; | |
| "1.1-8.15".sha256 = ""; | |
| "1.1-8.14".sha256 = "sha256-6vViCNQl6BnGgOHX3P/OLfFXN4aUfv4RbDokfz2BgQI="; | |
| "1.1-8.15".sha256 = "sha256-qCD3wFW4E+8vSVk4XoZ0EU4PVya0al+JorzS9nzmR/0="; |
kyoDralliam
force-pushed
the
metacoq-fix-dev
branch
from
83a6a18
to
fb3c486
Compare
|
Sorry, I messed up my commits. It seems that the CI went through with the right hashes. |
vbgl
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes