Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iperf: broken on darwin #19669

Closed
acowley opened this issue Oct 19, 2016 · 4 comments
Closed

iperf: broken on darwin #19669

acowley opened this issue Oct 19, 2016 · 4 comments
Labels
0.kind: bug 6.topic: darwin Running or building packages on Darwin

Comments

@acowley
Copy link
Contributor

acowley commented Oct 19, 2016

Issue description

iperf3 does not build on darwin

Steps to reproduce

Consult the hydra build log

Technical details

I think _mach_init_routine needs to be added to pkgs/os-specific/darwin/apple-source-releases/Libsystem/system_kernel_symbols but I have not tested this as it requires a lot of compiling.

  • System: darwin
  • Nix version: 1.11.4
  • Nixpkgs version: "17.03pre-git"
@acowley
Copy link
Contributor Author

acowley commented Oct 19, 2016

A bit more detail on why I suggested what I did since I may well be misinterpreting something. On OS X 10.11.6

$ nm /usr/lib/libSystem.dylib | grep "_mach"
                 U __mach_fork_child
0000000000001b56 t _mach_init_old
00000000000022b0 D _mach_init_routine

And if, when building iperf3, I manually run the failing step with the addition of -L/usr/lib -lSystem, it links successfully.

@NeQuissimus NeQuissimus added 0.kind: bug 6.topic: darwin Running or building packages on Darwin labels Oct 19, 2016
@mitchty
Copy link
Contributor

mitchty commented Nov 8, 2016

As a note, adding _mach_init_routine to the system_kernel_symbols gets iperf working again. No issues in anything else I use. I'll submit a PR tonight if I remember.

@LnL7
Copy link
Member

LnL7 commented Nov 8, 2016

adding the symbol to system_kernel_modules works by accident, I'm testing some changes that fix this properly.

@LnL7
Copy link
Member

LnL7 commented Nov 9, 2016

I pushed the fix to staging 16a9083

@LnL7 LnL7 closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 6.topic: darwin Running or building packages on Darwin
Projects
Status: Done
Development

No branches or pull requests

4 participants