Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 when clicking "how to Review contributions" in contributing.md #20594

Closed
falsifian opened this issue Nov 21, 2016 · 4 comments
Closed

404 when clicking "how to Review contributions" in contributing.md #20594

falsifian opened this issue Nov 21, 2016 · 4 comments

Comments

@falsifian
Copy link
Contributor

Issue description

At the end of CONTRIBUTING.md is a link "Review contributions".

When I click it, I'm redirected to http://hydra.nixos.org/build/43818136/download/1/nixpkgs/manual.html#chap-reviewing-contributions , which gives an HTTP 404.

Steps to reproduce

Click the last link in CONTRIBUTING.md.
@vcunat
Copy link
Member

vcunat commented Nov 21, 2016

Hmm, I don't know how to get there. Our Hydra front end doesn't store files anymore and this part isn't present http://nixos.org/ yet because it wasn't added to 16.09. /cc @ericsagnes.

@ericsagnes
Copy link
Contributor

Hydra issue NixOS/hydra#321.
Shall we remove that link until this is fixed?

@vcunat
Copy link
Member

vcunat commented Nov 22, 2016

@ericsagnes: this topic could well get cherry-picked to 16.09 and thus appear on nixos.org soon, but I don't understand why it's always mentioning nixpkgs but got added to nixos manual (even the link is wrong).

@ericsagnes ericsagnes mentioned this issue Nov 22, 2016
Merged
7 tasks
@ericsagnes
Copy link
Contributor

but I don't understand why it's always mentioning nixpkgs but got added to nixos manual (even the link is wrong).

@vcunat This was indeed a mistake, thanks for noticing!

@vcunat vcunat closed this as completed in b59167c Nov 24, 2016
vcunat added a commit that referenced this issue Nov 24, 2016
@vcunat
CONTRIBUTING.md: switch to a link that actually works
0d26209 
Fixes #20594.

(cherry picked from commit b59167c)
Also another link was switched from Hydra to https://nixos.org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@falsifian @ericsagnes @vcunat