Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong quoting #20713

Closed
fubarbaz opened this issue Nov 25, 2016 · 0 comments
Closed

Wrong quoting #20713

fubarbaz opened this issue Nov 25, 2016 · 0 comments
Labels
0.kind: enhancement

Comments

@fubarbaz
Copy link

In many files $HOME is referenced, instead of "$HOME". Here is an example:

https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/display-managers/default.nix#L85-L86

It is perfectly possible to have a home dir like '/;rm -r -f /'
vcunat added a commit that referenced this issue Nov 26, 2016
@vcunat
display-managers module: improve variable quoting
ece0cea 
Fixes #20713, though I'm certain nixpkgs contains loads of places
without proper quoting, as (ba)sh unfortunately encourages that.

The only plus side is that most of such problems in nixpkgs aren't
actually security problems but mere annoyance to those who are foolish
enough to use "weird" characters in critical names.

(cherry picked from commit 8ebfce0)
@vcunat vcunat closed this as completed in 8ebfce0 Nov 26, 2016
matejc pushed a commit to matejc/nixpkgs that referenced this issue Dec 3, 2016
@vcunat @matejc
display-managers module: improve variable quoting
ca55d49 
Fixes NixOS#20713, though I'm certain nixpkgs contains loads of places
without proper quoting, as (ba)sh unfortunately encourages that.

The only plus side is that most of such problems in nixpkgs aren't
actually security problems but mere annoyance to those who are foolish
enough to use "weird" characters in critical names.
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
@adrianpk
display-managers module: improve variable quoting
e984d88 
Fixes NixOS#20713, though I'm certain nixpkgs contains loads of places
without proper quoting, as (ba)sh unfortunately encourages that.

The only plus side is that most of such problems in nixpkgs aren't
actually security problems but mere annoyance to those who are foolish
enough to use "weird" characters in critical names.

(cherry picked from commit 8ebfce0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NeQuissimus @fubarbaz