Chromium maintenance #213862

primeos · 2023-01-31T22:23:23Z

Just an experiment / meta issue to track Chromium build failures, for coordination, etc (it'll be a bit noisy).

Chromium-specific documentation: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/browsers/chromium/README.md

cc #197609

primeos · 2023-01-31T22:27:06Z

The M110 (chromiumBeta) patch phase currently fails with the following error (easy to fix, we just need to adapt the build expressions to some upstream changes):

patchPhase completed in 40 seconds
configuring
WARNING at the command-line "--args":1:605: Build argument has no effect.
blink_symbol_level=0 chrome_pgo_phase=0 clang_base_path="/nix/store/fbgm8dzw6v3z2yv7p4zmiv7n0cx5y1dc-clang-wrapper-14.0.6" clang_use_chrome_plugins=false custom_toolchain="//build/toolchain/linux/unbundle:default" disable_fieldtrial_testing_config=true enable_hangout_services_extension=true enable_nacl=false enable_widevine=true ffmpeg_branding="Chrome" google_api_key="AIzaSyDGi15Zwl11UNe6Y-5XW_upsfyw31qwZPI" host_toolchain="//build/toolchain/linux/unbundle:default" is_official_build=true link_pulseaudio=true proprietary_codecs=true rtc_use_pipewire=true symbol_level=0 system_wayland_scanner_path="/nix/store/z9hm1agx9r7hjzlz6grfb57l4rr2ns81-wayland-1.21.0-bin/bin/wayland-scanner" treat_warnings_as_errors=false use_cups=true use_gio=true use_gnome_keyring=false use_pulseaudio=true use_qt=false use_sysroot=false use_system_libwayland=true
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ^-----------------------------------------------------------------------------------
The variable "system_wayland_scanner_path" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <out_dir>"

The build continued as if that argument was unspecified.

Done. Made 18355 targets from 3147 files in 8059ms
WARNING
Found gn WARNING, exiting nix build
error: builder for '/nix/store/xl8bbllmpx7scha2njwspy8kzhrhvnn5-chromium-unwrapped-110.0.5481.52.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/ymy0mfggwbwbwii1k2djpxdj8kr370xz-chromium-beta-110.0.5481.52.drv' failed to build

Upstream dropped use_system_libwayland and related build arguments [0]. The deprecation is tracked in [1]. As a result, we must now build with third_party/wayland instead of wayland from the system (or complex patches would be required). This fixes [2]. [0]: https://source.chromium.org/chromium/chromium/src/+/1c3c8db518f78cb2d08a3990e5280e324c4a6e99 [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1385736 [2]: NixOS#213862 (comment)

primeos · 2023-01-31T22:48:07Z

TODOs for M110:

Test if it builds (~~I'm currently running a build~~)
Test if the VM test passes
Try to build with LLVM 15 which is finally in Nixpkgs (it might even already be required for M110 to build): llvmPackages_15: init at 15.0.7 #194634
Cleanups (e.g., dropping wayland from the build inputs; more cleanups are overdue in general)

primeos · 2023-02-01T18:22:23Z

Next issue (expected / we already got this in the past when building with the bundled wayland):

building
ninja: Entering directory `out/Release'
[1950/1950] LINK ./mksnapshot.stampmksnapshot.stamptamp.stamporm_v8.oK[K[K)fault)
ninja: Entering directory `out/Release'
[3/3] LINK ./chrome_sandboxome_sandbox/sandbox.o_linux.o
ninja: Entering directory `out/Release'
[9956/52365] CC obj/third_party/fontconfig/fontconfig/fcxml.ooKK.oin/linux/unbundle:default)bundle:default)linux/unbundle:default)ault)lt)Kle:default)efault)[Kult)undle:default)imization_guide_internals.mojom-webui.js
../../third_party/fontconfig/src/src/fcxml.c:3609:6: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
            strerror_r (errno_, ebuf, BUFSIZ);
            ^~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[17177/52365] CXX obj/third_party/dawn/src/dawn/native/sources/ShaderModule.o[K[K.o[K.otrinary-minmax.stampoolchain/linux/unbundle:default)default)ault)
../../third_party/dawn/src/dawn/native/ShaderModule.cpp:532:21: warning: unused variable 'id2Scalar' [-Wunused-variable]
        const auto& id2Scalar = inspector->GetOverrideDefaultValues();
                    ^
1 warning generated.
[18132/52365] SOLINK ./libvk_swiftshader.sor/src/WSI/WSI.stampfaceKHR.otiopus/audio_encoder_multi_channel_opus.oautogen.ootocol.odle:default)
FAILED: libvk_swiftshader.so libvk_swiftshader.so.TOC
python3 "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm"  --sofile="./libvk_swiftshader.so" --tocfile="./libvk_swiftshader.so.TOC" --output="./libvk_swiftshader.so" -- clang++ -shared -Wl,-soname="libvk_swiftshader.so" -Wl,-Bsymbolic -Wl,--version-script=../../third_party/swiftshader/src/Vulkan/vk_swiftshader.lds -fuse-ld=lld -Wl,--fatal-warnings -Wl,--build-id=sha1 -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,--icf=all -Wl,--color-diagnostics -Wl,-mllvm,-instcombine-lower-dbg-declare=0 -flto=thin -Wl,--thinlto-jobs=all -Wl,--thinlto-cache-dir=thinlto-cache -Wl,--thinlto-cache-policy=cache_size=10\%:cache_size_bytes=40g:cache_size_files=100000 -Wl,-mllvm,-import-instr-limit=30 -fwhole-program-vtables -Wl,--undefined-version -Wl,--no-call-graph-profile-sort -m64 -no-canonical-prefixes -Wl,-O2 -Wl,--gc-sections -rdynamic -Wl,-z,defs -Wl,--as-needed -nostdlib++ -Wl,--lto-O0 -fsanitize=cfi-vcall -fsanitize=cfi-icall -o "./libvk_swiftshader.so" @"./libvk_swiftshader.so.rsp"
ld.lld: error: unable to find library -l:libffi_pic.a
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
[18135/52365] CXX obj/third_party/webrtc/api/crypto/options/crypto_options.oltiopus/audio_encoder_multi_channel_opus.o
ninja: build stopped: subcommand failed.
error: builder for '/nix/store/5rccszwvkdxvxc63ry8xba8wn6ambh1p-chromium-unwrapped-110.0.5481.52.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/innzdg1hhqaxjakialpbsdxmmya1ha3h-chromium-beta-110.0.5481.52.drv' failed to build

CyborgPotato · 2023-02-04T20:26:56Z

Have been trying to get it to work on a local build, and it seems the flag that would be necessary/an easy solution would be to make use of systemffi, as was added in this commit (v107):

chromium/chromium@cf3ee09

This change (dynamically linking against libffi from Nixpkgs) is required since we switched to third_party/wayland instead of linking against Wayland from Nixpkgs (26aadca). See also f9d9864 and d932886 for more details. We could alternatively provide libffi_pic.a for static linking but due to our immutable dependency model / pure builds the dynamic linking shouldn't cause any issues. This fixes the build error shown in [0]. [0]: NixOS#213862 (comment)

primeos · 2023-02-06T22:13:48Z

@DavidCromp yes, thanks :) We already discovered this issue and possible solutions in the past but I decided to stick with using Wayland from Nixpkgs back then. I already fixed it locally but forgot / didn't get around to submit the change.

primeos · 2023-02-06T22:18:38Z

The build and VM test both pass now :)

/nix/store/wk63f6dl3f4v920smlawj5fw9p6mx9qr-chromium-beta-110.0.5481.52
/nix/store/33f1i1pvha1dmhrsy9bvw65dlsdvg51q-vm-test-run-chromium-beta

I also just start a build of M111 / chromeDev to see if there's more work left (which would be a good challenge for new/additional maintainers as there's enough time to fix those issues - unlike M110 which will be released tomorrow).

Upstream dropped use_system_libwayland and related build arguments [0]. The deprecation is tracked in [1]. As a result, we must now build with third_party/wayland instead of wayland from the system (or complex patches would be required). This fixes [2]. [0]: https://source.chromium.org/chromium/chromium/src/+/1c3c8db518f78cb2d08a3990e5280e324c4a6e99 [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1385736 [2]: NixOS#213862 (comment) (cherry picked from commit 26aadca)

This change (dynamically linking against libffi from Nixpkgs) is required since we switched to third_party/wayland instead of linking against Wayland from Nixpkgs (26aadca). See also f9d9864 and d932886 for more details. We could alternatively provide libffi_pic.a for static linking but due to our immutable dependency model / pure builds the dynamic linking shouldn't cause any issues. This fixes the build error shown in [0]. [0]: NixOS#213862 (comment) (cherry picked from commit 06eb99f)

This change (dynamically linking against libffi from Nixpkgs) is required since we switched to third_party/wayland instead of linking against Wayland from Nixpkgs (26aadca). See also f9d9864 and d932886 for more details. We could alternatively provide libffi_pic.a for static linking but due to our immutable dependency model / pure builds the dynamic linking shouldn't cause any issues. This fixes the build error shown in [0]. [0]: NixOS#213862 (comment)

Upstream dropped use_system_libwayland and related build arguments [0]. The deprecation is tracked in [1]. As a result, we must now build with third_party/wayland instead of wayland from the system (or complex patches would be required). This fixes [2]. [0]: https://source.chromium.org/chromium/chromium/src/+/1c3c8db518f78cb2d08a3990e5280e324c4a6e99 [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1385736 [2]: NixOS#213862 (comment) (cherry picked from commit 26aadca)

This change (dynamically linking against libffi from Nixpkgs) is required since we switched to third_party/wayland instead of linking against Wayland from Nixpkgs (26aadca). See also f9d9864 and d932886 for more details. We could alternatively provide libffi_pic.a for static linking but due to our immutable dependency model / pure builds the dynamic linking shouldn't cause any issues. This fixes the build error shown in [0]. [0]: NixOS#213862 (comment) (cherry picked from commit 06eb99f)

primeos · 2023-03-11T18:31:08Z

chromiumDev (113.0.5638) is broken again:

[43269/53220] CXX obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o.oor.o[KKrator.oontext.ocreencanvasrenderingcontext2d_webgl2renderingcontext_webglrenderingcontext.otsi.tsts
FAILED: obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o
clang++ -MMD -MF obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=e136ec5032a5e5d97e988ce66e8c269a80ff54c4 -D_LIBCPP_ENABLE_ASSERTIONS=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DLIBYUV_DISABLE_NEON -DUSE_EGL -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_WAYLAND_KHR -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DWEBRTC_ENABLE_AVX2 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_X11 -DWEBRTC_USE_PIPEWIRE -DWEBRTC_USE_GIO -DLOGGING_INSIDE_WEBRTC -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_WUFFS_LIBRARY -DSK_VULKAN=1 -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_SLIM_WRITE_BARRIER -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DWTF_USE_WEBAUDIO_PFFFT=1 -DUSE_INNER_HTML_PARSER_FAST_PATH=1 -DUSE_SYSTEM_LIBJPEG -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -Igen/shim_headers/libpng_shim -Igen/shim_headers/libwebp_shim -I../../third_party/vulkan-deps/vulkan-headers/src/include -I../../third_party/wayland/src/src -I../../third_party/wayland/include/src -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/khronos -I../../gpu -Igen/shim_headers/flac_shim -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/skia -I../../third_party/wuffs/src/release/c -I../../third_party/vulkan/include -I../../v8/include -Igen/v8/include -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/linux -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -I../../third_party/iccjpeg -I../../third_party/ots/src/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/snappy/src -I../../third_party/snappy/linux -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -fwhole-program-vtables -fcomplete-member-pointers -m64 -msse3 -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -fsanitize=cfi-vcall -fsanitize-ignorelist=../../tools/cfi/ignores.txt -fsanitize=cfi-icall -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wglobal-constructors -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -g0 -I/nix/store/152gsygyjagsirvdg3icmz4px39wddwj-glib-2.74.5-dev/include -I/nix/store/152gsygyjagsirvdg3icmz4px39wddwj-glib-2.74.5-dev/include/glib-2.0 -I/nix/store/rcwsvm3zmcpwl71b7r5f9ql599hw6f2b-glib-2.74.5/lib/glib-2.0/include -Wno-redundant-parens -Wconversion -Wno-float-conversion -Wno-sign-conversion -Wno-implicit-float-conversion -Wno-implicit-int-conversion -DPROTOBUF_ALLOW_DEPRECATED=1 -I/nix/store/5q9cn8i6qrl6fycmgj8jkzrqhkml1g8h-nspr-4.35-dev/include -I/nix/store/7nk5x7ds6wcp7vpfngd969ad9axk6pav-nss-3.79.4-dev/include/nss -Wno-redundant-parens -I/nix/store/kkdn8237y00qqwg2lqz43v25pbrkb2n3-libpng-1.6.39-dev/include/libpng16 -DLIBXML_STATIC= -I/nix/store/i57f5lhc83sfnck9d6rik0dbnbxr9qlw-libxslt-1.1.37-dev/include -I/nix/store/0z5wasald7dmipjpbx8kw31pj0kzjxpg-libxml2-2.10.3-dev/include/libxml2 -std=c++20 -Wno-trigraphs -gsimple-template-names -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -c ../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc -o obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:530:28: error: reference to local binding 'grid_items' declared in enclosing function 'blink::NGGridLayoutAlgorithm::BuildGridSizingSubtree'
    for (auto& grid_item : grid_items) {
                           ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:512:10: note: 'grid_items' declared here
  auto& [grid_items, layout_data, subtree_size] =
         ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:540:5: error: reference to local binding 'layout_data' declared in enclosing function 'blink::NGGridLayoutAlgorithm::BuildGridSizingSubtree'
    layout_data.SetTrackCollection(
    ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:512:22: note: 'layout_data' declared here
  auto& [grid_items, layout_data, subtree_size] =
                     ^
2 errors generated.
[43272/53220] CXX obj/third_party/blink/renderer/core/core/ng_grid_node.olver.oion.o
ninja: build stopped: subcommand failed.
error: builder for '/nix/store/1dfhn82935xg4ac6ds7fkfch5d8v18zi-chromium-unwrapped-113.0.5638.0.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/qqqlng8hf65vbdmss3hk34l0y35yvw1w-chromium-dev-113.0.5638.0.drv' failed to build

Maybe LLVM 15 is already too "old" to build M113 but I haven't looked into it yet.

lorenz · 2023-03-11T22:50:28Z

Compiler bug in LLVM <= 15. Requires LLVM 16 or higher (unreleased). See also llvm/llvm-project#48582.

RaitoBezarius · 2023-03-11T22:54:48Z

Compiler bug in LLVM <= 15. Requires LLVM 16 or higher (unreleased). See also llvm/llvm-project#48582.

Nice. I have started a llvm16 branch (https://github.com/nixos/nixpkgs/tree/llvm16) that's still very wipy.
I opened llvm/llvm-project#61350 because I am not able to solve this failing test.

RaitoBezarius · 2023-03-26T19:54:36Z

@primeos FWIW, #223282 has been opened. Hopefully, it should get us the fix for Chromium.

Hopefully as we land all the LLVM maintenance stuff, this should get us unstuck.

primeos · 2023-03-31T12:53:59Z

Thanks a lot @RaitoBezarius and @lorenz! :)
It's great to have a PR for LLVM 16! :)

primeos · 2023-05-09T20:34:46Z

M114 seems to require libevdev as new dependency:

./ios/chrome/test/wpt/tools/run_clusterfuzz_test.sh: interpreter directive changed from "#!/bin/bash" to "/nix/store/zlf0f88vj30sc7567b80l52d19pbdmy2-bash-5.2-p15/bin/bash"
patchPhase completed in 35 seconds
configuring
ERROR at //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit code.
    pkgresult = exec_script(pkg_config_script, args, "value")
                ^----------
Current dir: /tmp/nix-build-chromium-unwrapped-114.0.5696.0.drv-0/chromium-114.0.5696.0/out/Release/
Command: python3 /tmp/nix-build-chromium-unwrapped-114.0.5696.0.drv-0/chromium-114.0.5696.0/build/config/linux/pkg-config.py libevdev
Returned 1.
stderr:

Package libevdev was not found in the pkg-config search path.
Perhaps you should add the directory containing `libevdev.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libevdev' found
Could not run pkg-config.

See //remoting/host/BUILD.gn:232:3: whence it was called.
  pkg_config("libevdev") {
  ^-----------------------
See //BUILD.gn:890:7: which caused the file to be included.
      "//remoting/host:host",
      ^---------------------
note: keeping build directory '/tmp/nix-build-chromium-unwrapped-114.0.5696.0.drv-0'
error: builder for '/nix/store/zv07amm3y57h6ssczx3588bqfk8yjixd-chromium-unwrapped-114.0.5696.0.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/f3m6f3m596az3k0qcf793ahivlfkcz3b-chromium-dev-114.0.5696.0.drv' failed to build

RaitoBezarius · 2023-05-10T11:02:59Z

But we do have libevdev in nixpkgs, right?

The configuration phase was failing with "No package 'libevdev' found". See [0] for the full output. The build phase is still failing and we probably need to use a patch to avoid requiring a newer, unreleased LLVM version. [0]: NixOS#213862 (comment)

primeos · 2023-05-10T22:23:57Z

Yes, that issue is luckily trivial to fix but I expected additional issues so I didn't commit the fix right away. But I've included it in 5267a34 now.

Anyway, unfortunately it's worse than I thought as it looks like the build scripts aren't compatible with LLVM 16 anymore and LLVM 17 definitely won't be out when M114 releases. I guess we'll have to patch the source code or rather build scripts (either by reverting the commit that introduced the problematic changes (preferred, if it's a dedicated commit) or by writing a custom patch.

I'm getting the following error now:

patchPhase completed in 34 seconds
configuring
Done. Made 17938 targets from 3224 files in 8763ms
building
ninja: Entering directory `out/Release'
[854/2934] LINK ./protocparty/perfetto/gn/protoc_lib.stampKk.osion_utils_portable.oorter_module.o.oK
FAILED: protoc
"python3" "../../build/toolchain/gcc_link_wrapper.py" --output="./protoc" -- clang++ -fuse-ld=lld -Wl,--fatal-warnings -Wl,--build-id=sha1 -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,--icf=all -Wl,--color-diagnostics -Wl,-mllvm,-instcombine-lower-dbg-declare=0 -flto=thin -Wl,--thinlto-jobs=all -Wl,--thinlto-cache-dir=thinlto-cache -Wl,--thinlto-cache-policy=cache_size=10\%:cache_size_bytes=40g:cache_size_files=100000 -Wl,-mllvm,-import-instr-limit=30 -Wl,-mllvm,-disable-auto-upgrade-debug-info -fwhole-program-vtables -Wl,--undefined-version -Wl,--no-call-graph-profile-sort -m64 -no-canonical-prefixes -Wl,-O2 -Wl,--gc-sections -rdynamic -Wl,-z,defs -Wl,--as-needed -nostdlib++ -Wl,--lto-O0 -fsanitize=cfi-vcall -fsanitize=cfi-icall -pie -Wl,--disable-new-dtags -o "./protoc" -Wl,--start-group @"./protoc.rsp"  -Wl,--end-group  -ldl -lpthread -lrt
ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'.  Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help'
ld.lld: Did you mean '--disable-auto-paired-vec-st'?
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
[857/2934] CXX obj/v8/v8_bigint/div-burnikel.o
ninja: build stopped: subcommand failed.
note: keeping build directory '/tmp/nix-build-chromium-unwrapped-114.0.5735.16.drv-0'
error: builder for '/nix/store/krrwbfk0zkrf3jnfwabb5d35845prxga-chromium-unwrapped-114.0.5735.16.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/2y9spz2hyvymrdidlv1w7f4zjag2f0zv-chromium-beta-114.0.5735.16.drv' failed to build

Does someone have the time and motivation to investigate? Maybe there's already an upstream "bug" report with useful information/discussion or patches from other packagers.

lorenz · 2023-05-10T23:21:15Z

We don't care about this flag, I'd personally just revert https://chromium-review.googlesource.com/c/chromium/src/+/4470209, which should be fairly self-contained and maintainable.

But longer term I think we need to come to terms with the fact that Chromium pins their own LLVM toolchain which is close to master and does not guarantee compatibility with anything else (especially if it is older). Considering the amount of QA and other things they do to it it might make sense to just package their toolchain.

alyssais · 2023-05-11T09:33:07Z

I've sent a message to the distributions list to try to get a cross-distro perspective on this.

This reverts a small commit [0] that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message: ``` ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'. Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help' ld.lld: Did you mean '--disable-auto-paired-vec-st'? clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` See [1] for a full example output. Thanks to Lorenz Brun for the analysis/help [2]. [0]: chromium/chromium@5496976 [1]: NixOS#213862 (comment) [2]: NixOS#213862 (comment)

This reverts a small commit [0] that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message: ``` ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'. Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help' ld.lld: Did you mean '--disable-auto-paired-vec-st'? clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` See [1] for a full example output. Thanks to Lorenz Brun for the analysis/help [2]. [0]: chromium/chromium@5496976 [1]: NixOS#213862 (comment) [2]: NixOS#213862 (comment) (cherry picked from commit 16f87c4)

The configuration phase was failing with "No package 'libevdev' found". See [0] for the full output. The build phase is still failing and we probably need to use a patch to avoid requiring a newer, unreleased LLVM version. [0]: NixOS#213862 (comment) (cherry picked from commit 5267a34)

This reverts a small commit [0] that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message: ``` ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'. Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help' ld.lld: Did you mean '--disable-auto-paired-vec-st'? clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` See [1] for a full example output. Thanks to Lorenz Brun for the analysis/help [2]. [0]: chromium/chromium@5496976 [1]: NixOS#213862 (comment) [2]: NixOS#213862 (comment) (cherry picked from commit 16f87c4)

terraform-providers.infoblox: 2.3.0 -> 2.4.0 terraform-providers.pagerduty: 2.14.5 -> 2.14.6 terraform-providers.scaleway: 2.19.0 -> 2.20.0 build(deps): bump cachix/install-nix-action from 20 to 21 Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 20 to 21. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](cachix/install-nix-action@v20...v21) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> powershell: drop openssl_1_1 zinit: 3.7 -> 3.11.0 picard: Fix inputs Add qt5.qtwayland - for the wrapper. Put most qt5 inputs in `buildInputs` - not `nativeBuildInputs`. Remove `fetchpatch` unused argument. prom2json: 1.3.2 -> 1.3.3 httplib: 0.12.3 -> 0.12.4 credhub-cli: 2.9.15 -> 2.9.16 rust-analyzer-unwrapped: 2023-05-22 -> 2023-05-29 goflow2: 1.3.3 -> 1.3.4 webhook: 2.8.0 -> 2.8.1 vtm: 0.9.9k -> 0.9.9l linux_xanmod: 6.1.29 -> 6.1.30 pdal: 2.4.3 -> 2.5.4 powershell: 7.3.2 -> 7.3.4 cloudflared: 2023.5.0 -> 2023.5.1 pqrs: 0.2.2 -> 0.3.1 signalbackup-tools: 20230523 -> 20230528-1 clickhouse-backup: 2.2.6 -> 2.2.7 amazon-ecr-credential-helper: 0.7.0 -> 0.7.1 flacon: 11.0.0 -> 11.1.0 plumed: 2.8.2 -> 2.9.0 limitcpu: 2.9 -> 3.0 frp: 0.48.0 -> 0.49.0 minio-client: 2023-05-18T16-59-00Z -> 2023-05-26T23-31-54Z netbird-ui: 0.20.3 -> 0.20.5 dagger: 0.5.3 -> 0.6.0 re-flex: 3.3.2 -> 3.3.3 pacparser: 1.4.1 -> 1.4.2 clj-kondo: 2023.05.18 -> 2023.05.26 flrig: 1.4.8 -> 2.0.0 router: 1.18.1 -> 1.19.0 theforceengine: 1.09.100 -> 1.09.200 lhasa: 0.3.1 -> 0.4.0 guile-opengl: 0.1.0 -> 0.2.0 shotman: 0.4.1 -> 0.4.3 pleroma: 2.5.1 -> 2.5.2 Security update, fixes a critical bug in the media proxy. The crypt dependency was removed, dropping the libxcrypt-legacy workaround \0/. Full changelog there: https://git.pleroma.social/pleroma/pleroma/-/releases/v2.5.2 buildGoModule: format Co-authored-by: Yueh-Shun Li <shamrocklee@posteo.net> memcached: 1.6.19 -> 1.6.20 krill: 0.12.3 -> 0.13.0 calico-pod2daemon: 3.25.1 -> 3.26.0 python311Packages.django-rest-registration: 0.7.3 -> 0.8.2 buildkite-agent: 3.46.1 -> 3.47.0 invidious: unstable-2023-05-08 -> 2023-05-25 eksctl: 0.142.0 -> 0.143.0 python310Packages.azure-containerregistry: 1.0.0 -> 1.1.0 python310Packages.azure-containerregistry: update disabled - add format - add missing input prometheus-node-exporter: 1.5.0 -> 1.6.0 prometheus-pushgateway: 1.5.1 -> 1.6.0 supabase-cli: 1.64.2 -> 1.64.8 gopsuinfo: 0.1.3 -> 0.1.4 clamav: 1.0.1 -> 1.1.0 keama: init at 4.4.3-P1 rathole: 0.4.7 -> 0.4.8 rl-2305: alpha version for 23.05 This is an alpha version worked out by the release managers. Co-Authored-By: Martin Weinelt <hexa@darmstadt.ccc.de> doc: clarify that meta.timeout is only for Hydra I read this and expected it to be a timeout that was always applied when building the derivation, but it's actually a Hydra-specific thing. python3.pkgs.glean-sdk: unvendor lmdb asnmap: 1.0.3 -> 1.0.4 gpg-tui: 0.9.5 -> 0.9.6 catnip: init at 1.8.0 https://github.com/noriah/catnip ddnet: 17.0 -> 17.0.1 https://ddnet.org/downloads/#17.0.1 ddnet: 17.0.1 -> 17.0.2 https://ddnet.org/downloads/#17.0.2 lightning-loop: 0.23.0-beta -> 0.24.1-beta mongodb-compass: 1.36.4 -> 1.37.0 maddy: 0.6.3 -> 0.7.0 Diff: foxcpp/maddy@v0.6.3...v0.7.0 nixos/maddy: change secrets option to accept a list of paths flirc: lock readline to 6.x version as required libreoffice-still: 7.4.6.2 -> 7.4.7.2 libreoffice-fresh: 7.5.2.2 -> 7.5.4.1 snagboot: init at 1.0 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> nixos/vmalert: init xfce.xfce4-session: 4.18.2 -> 4.18.3 https://gitlab.xfce.org/xfce/xfce4-session/-/compare/xfce4-session-4.18.2...xfce4-session-4.18.3 grype: 0.62.1 -> 0.62.2 Diff: anchore/grype@refs/tags/v0.62.1...v0.62.2 Changelog: https://github.com/anchore/grype/releases/tag/v0.62.2 flyctl: 0.1.18 -> 0.1.20 python3Packages.langchain: 0.0.183 -> 0.0.184 Diff: langchain-ai/langchain@refs/tags/v0.0.183...v0.0.184 Changelog: https://github.com/hwchase17/langchain/releases/tag/v0.0.184 ockam: 0.87.0 -> 0.88.0 openssl_1_1: 1.1.1t -> 1.1.1u https://github.com/openssl/openssl/blob/OpenSSL_1_1_1u/NEWS Fixes: CVE-2023-2650, CVE-2023-0466, CVE-2023-0465, CVE-2023-0464 maintainers: add flemzord moon: init at v1.5.1 oxidized: 0.26.3 -> 0.29.1 (NixOS#234001) This commit updates oxidized, fixes the oxidized-script executable and removes the non existing oxidized-web executable (oxidized-web is just a library for oxidized and does not provide a executable). python310Packages.pydyf: 0.5.0 -> 0.6.0 python310Packages.weasyprint: 58.1 -> 59.0 vencord: 1.1.6 -> 1.2.5 denaro: 2023.2.2 -> 2023.5.0; add updateScript python311Packages.pyzipper: init at 0.3.6 python311Packages.xknxproject: init at 3.1.0 python311Packages.aioairzone-cloud: init at 0.1.6 bun: 0.6.3 -> 0.6.5 nixVersions.nix_2_15: 2.15.0 -> 2.15.1 hyprwm: update packages hyprland: 0.25.0 -> 0.26.0 hyprpaper: 0.2.0 -> 0.4.0 hyprpicker: 0.1.0 -> 0.1.1 xdg-desktop-portal-hyprland: 0.3.1 -> 0.4.0 python311Packages.dvc-data: 0.52.0 -> 0.53.0 Diff: iterative/dvc-data@refs/tags/0.52.0...0.53.0 Changelog: https://github.com/iterative/dvc-data/releases/tag/0.53.0 cameradar: Mark as broken qmidiarp: 0.6.7 -> 0.7.0 erdtree: 3.0.0 -> 3.0.1 Diff: solidiquis/erdtree@v3.0.0...v3.0.1 Changelog: https://github.com/solidiquis/erdtree/releases/tag/v3.0.1 haruna: 0.10.3 -> 0.11.0 python3Packages.mautrix: 0.19.14 -> 0.19.16 Diff: mautrix/python@refs/tags/v0.19.14...v0.19.16 Changelog: https://github.com/mautrix/python/releases/tag/v0.19.16 mautrix-telegram: 0.13.0 -> 0.14.0 Diff: mautrix/telegram@refs/tags/v0.13.0...v0.14.0 python311Packages.meshtastic: 2.1.6 -> 2.1.7 Diff: meshtastic/python@refs/tags/2.1.6...2.1.7 Changelog: https://github.com/meshtastic/python/releases/tag/2.1.7 python311Packages.aliyun-python-sdk-kms: 2.16.0 -> 2.16.1 Changelog: https://github.com/aliyun/aliyun-openapi-python-sdk/blob/master/aliyun-python-sdk-kms/ChangeLog.txt python311Packages.types-requests: 2.31.0.0 -> 2.31.0.1 chromiumBeta: 114.0.5735.35 -> 114.0.5735.45 chromiumDev: 115.0.5773.4 -> 115.0.5790.3 runme: 1.2.1 -> 1.2.2 Diff: stateful/runme@v1.2.1...v1.2.2 Changelog: https://github.com/stateful/runme/releases/tag/vv1.2.2 linux: 4.14.315 -> 4.14.316 linux: 4.19.283 -> 4.19.284 linux: 5.10.180 -> 5.10.181 linux: 5.15.113 -> 5.15.114 linux: 5.4.243 -> 5.4.244 linux: 6.1.30 -> 6.1.31 linux: 6.3.4 -> 6.3.5 linux-rt_5_15: 5.15.111-rt63 -> 5.15.113-rt64 linux_latest-libre: 19299 -> 19308 linux/hardened/patches/4.14: 4.14.314-hardened1 -> 4.14.315-hardened1 linux/hardened/patches/4.19: 4.19.282-hardened1 -> 4.19.283-hardened1 linux/hardened/patches/5.10: 5.10.179-hardened1 -> 5.10.180-hardened1 linux/hardened/patches/5.15: 5.15.111-hardened1 -> 5.15.112-hardened1 linux/hardened/patches/5.4: 5.4.242-hardened1 -> 5.4.243-hardened1 linux/hardened/patches/6.1: 6.1.28-hardened1 -> 6.1.29-hardened1 rbdoom-3-bfg: 1.5.0 -> 1.5.1 python311Packages.tplink-omada-client: 1.2.5 -> 1.3.0 Changelog: https://github.com/MarkGodwin/tplink-omada-api/releases/tag/release%2Fv1.3.0 python310Packages.types-deprecated: init at 1.2.9.2 python311Packages.pyquil: 3.5.0 -> 3.5.2 Diff: rigetti/pyquil@refs/tags/v3.5.0...v3.5.2 Changelog: https://github.com/rigetti/pyquil/blob/v3.5.2/CHANGELOG.md python311Packages.intake-parquet: 0.2.3 -> 0.3.0 Diff: intake/intake-parquet@0.2.3...0.3.0 python310Packages.intake: 0.6.8 -> 0.7.0 Diff: intake/intake@refs/tags/0.6.8...0.7.0 Changelog: https://github.com/intake/intake/blob/0.7.0/docs/source/changelog.rst python311Packages.peaqevcore: 15.3.1 -> 18.0.6 Changelog: https://github.com/elden1337/peaqev-core/releases/tag/18.0.6 bearer: fix version bearer: add version test httpdump: 20210126-d2e0dea -> unstable-2023-05-07 python311Packages.python-roborock: 0.18.6 -> 0.18.9 Diff: humbertogontijo/python-roborock@refs/tags/v0.18.6...v0.18.9 Changelog: https://github.com/humbertogontijo/python-roborock/blob/v0.18.9/CHANGELOG.md python311Packages.python-roborock: add input for darwin python311Packages.zeroconf: 0.62.0 -> 0.63.0 Diff: python-zeroconf/python-zeroconf@refs/tags/0.62.0...0.63.0 Changelog: https://github.com/python-zeroconf/python-zeroconf/releases/tag/0.63.0 python311Packages.sentry-sdk: 1.21.1 -> 1.24.0 Diff: getsentry/sentry-python@refs/tags/1.21.1...1.24.0 Changelog: https://github.com/getsentry/sentry-python/blob/1.24.0/CHANGELOG.md laminar: 1.2 → 1.3 gh: 2.29.0 -> 2.30.0 Diff: cli/cli@v2.29.0...v2.30.0 Changelog: https://github.com/cli/cli/releases/tag/v2.30.0 chromiumBeta: Fix the build with LLVM 16 by reverting a commit This reverts a small commit [0] that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message: ``` ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'. Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help' ld.lld: Did you mean '--disable-auto-paired-vec-st'? clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` See [1] for a full example output. Thanks to Lorenz Brun for the analysis/help [2]. [0]: chromium/chromium@5496976 [1]: NixOS#213862 (comment) [2]: NixOS#213862 (comment) automatic-timezoned: 1.0.92 -> 1.0.93 python311Packages.aioesphomeapi: 13.7.5 -> 13.9.0 Diff: esphome/aioesphomeapi@refs/tags/v13.7.5...v13.9.0 Changelog: https://github.com/esphome/aioesphomeapi/releases/tag/v13.9.0 checkov: 2.3.261 -> 2.3.264 Diff: bridgecrewio/checkov@refs/tags/2.3.261...2.3.264 Changelog: https://github.com/bridgecrewio/checkov/releases/tag/2.3.264 jackett: 0.21.34 -> 0.21.88 helix: switch back to release tarball erlang_odbc_javac: 25.3.2 -> 25.3.2.1 yuzu: mainline 1437 -> 1452, early access 3596 -> 3621 rustypaste: 0.9.1 -> 0.10.0 Diff: orhun/rustypaste@v0.9.1...v0.10.0 Changelog: https://github.com/orhun/rustypaste/blob/v0.10.0/CHANGELOG.md dontgo403: 0.9.1 -> 0.9.3 libcyaml: 1.4.0 -> 1.4.1 shell_gpt: 0.9.0 -> 0.9.1 ledger-live-desktop: 2.58.0->2.60.0 ledger-live-desktop: 2.58.0->2.60.0 ocamlPackages.ocplib-endian: fix for OCaml 5.0 ocamlPackages.lwt: fix for OCaml 5.0 ocamlPackages.iter: 1.6 → 1.7 alt-ergo: 2.4.2 → 2.4.3 terraform-providers.akamai: 3.6.0 -> 4.0.0 terraform-providers.cloudflare: 4.6.0 -> 4.7.0 terraform-providers.google: 4.66.0 -> 4.67.0 terraform-providers.google-beta: 4.66.0 -> 4.67.0 terraform-providers.newrelic: 3.23.0 -> 3.24.0 terraform-providers.pagerduty: 2.14.6 -> 2.15.0 terraform-providers.snowflake: 0.64.0 -> 0.65.0 ruby: fix typo cocoapods: 1.12.0 -> 1.12.1 Updated using pkgs/development/tools/cocoapods/update python310Packages.openstacksdk: 1.1.0 -> 1.2.0 python3Packages.edk2-pytool-library: 0.15.0 -> 0.15.1 Diff: tianocore/edk2-pytool-library@v0.15.0...v0.15.1 Changelog: https://github.com/tianocore/edk2-pytool-library/releases/tag/v0.15.1 python310Packages.archinfo: 9.2.52 -> 9.2.53 python310Packages.ailment: 9.2.52 -> 9.2.53 python310Packages.pyvex: 9.2.52 -> 9.2.53 python310Packages.claripy: 9.2.52 -> 9.2.53 python310Packages.cle: 9.2.52 -> 9.2.53 python310Packages.angr: 9.2.52 -> 9.2.53 python311Packages.asysocks: 0.2.5 -> 0.2.7 Changelog: https://github.com/skelsec/asysocks/releases/tag/0.2.7 python311Packages.minikerberos: 0.4.0 -> 0.4.1 Changelog: https://github.com/skelsec/minikerberos/releases/tag/0.4.1 python311Packages.asyauth: 0.0.13 -> 0.0.14 Changelog: https://github.com/skelsec/asyauth/releases/tag/0.0.14 python311Packages.aiosmb: 0.4.4 -> 0.4.6 Changelog: https://github.com/skelsec/aiosmb/releases/tag/0.4.6 python311Packages.aiowinreg: 0.0.9 -> 0.0.10 Diff: skelsec/aiowinreg@refs/tags/0.0.9...0.0.10 Changelog: https://github.com/skelsec/aiowinreg/releases/tag/0.0.10 python311Packages.msldap: 0.4.7 -> 0.5.5 Changelog: https://github.com/skelsec/msldap/releases/tag/0.5.5 python311Packages.aesedb: 0.1.3 -> 0.1.4 Diff: skelsec/aesedb@refs/tags/0.1.3...0.1.4 Changelog: https://github.com/skelsec/aesedb/releases/tag/0.1.4 python311Packages.pypykatz: 0.6.6 -> 0.6.8 Changelog: https://github.com/skelsec/pypykatz/releases/tag/0.6.8 sleek: init at 0.3.0 blueberry: add missing libnotify ref: NixOS#234833 postgresql11JitPackages.pgroonga: 3.0.1 -> 3.0.3 postgresqlPackages.pgroonga: 3.0.3 -> 3.0.5 https://github.com/pgroonga/pgroonga/releases/tag/3.0.5 postgresqlPackages.pgroonga: add changelog to meta python310Packages.tubeup: 28.5.2023 -> 2023.5.29 Changelog: https://github.com/bibanon/tubeup/releases/tag/2023.5.29 python310Packages.ibm-cloud-sdk-core: 3.16.5 -> 3.16.6

primeos · 2023-06-13T22:03:10Z

It seems like M115 introduces some initial Rust support (https://security.googleblog.com/2023/01/supporting-use-of-rust-in-chromium.html, https://bugs.chromium.org/p/chromium/issues/detail?id=1292038):

patchPhase completed in 34 seconds
configuring
ERROR at //build/config/rust.gni:126:24: Script returned non-zero exit code.
      rustc_revision = exec_script("//tools/rust/update_rust.py",
                       ^----------
Current dir: /tmp/nix-build-chromium-unwrapped-115.0.5790.13.drv-0/chromium-115.0.5790.13/out/Release/
Command: python3 /tmp/nix-build-chromium-unwrapped-115.0.5790.13.drv-0/chromium-115.0.5790.13/tools/rust/update_rust.py --print-package-version
Returned 1 and printed out:

The expected Rust version is 2a8221dbdfd180a2d56d4b0089f4f3952d8c2bcd-1-llvmorg-17-init-10134-g3da83fba-2 (or fallback 2a8221dbdfd180a2d56d4b0089f4f3952d8c2bcd-1-llvmorg-17-init-10134-g3da83fba-1 but the actual version is None
Did you run "gclient sync"?

See //BUILD.gn:17:1: whence it was imported.
import("//build/config/rust.gni")
^-------------------------------
error: builder for '/nix/store/bfw2ylczj124z0gckvkc28jnxaa55mgj-chromium-unwrapped-115.0.5790.13.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/1vnmnv1qalpkz71nflqnv6jk4ncz6i0h-chromium-beta-115.0.5790.13.drv' failed to build

This could be quite challenging for Nixpkgs - depending on how well Google handles it (since scripts like update_rust.py cannot make any network requests inside the Nix build sandbox (except for fixed-output derivations)).

Does someone have time and motivation to look into this?

@lorenz huge thanks for your analysis in #213862 (comment) btw. I've credited you in primeos@16f87c4 - hope that's fine (I can also add you as co-author next time, if you want - alternatively you can of course also make a PR next time 😉).

lorenz · 2023-07-12T23:01:41Z

I read the new GN specs and plumbed in the nixpkgs Rust compiler. From a look at Chromium's upstream packaging they do not use a patched Rust, so this should be fine (as fine as not using their bespoke LLVM is). Build is still running, but didn't fail during GN phase. I'll send a PR once it finished building.

lorenz · 2023-07-13T09:37:06Z

115 built successfully, I'll submit a patch this evening or tomorrow.

lorenz · 2023-07-13T18:53:56Z

#243319

yu-re-ka · 2023-12-05T11:03:54Z

I'm debugging the build of electron 28 / chromium 120.x currently. One of the patches no longer applies.

yu-re-ka · 2023-12-06T10:56:03Z

patch for building chromium 120 with llvm 16 is in #271677, please review (built a chromium 120 beta on x86_64-linux and electron 28 on aarch64-linux)

This change (dynamically linking against libffi from Nixpkgs) is required since we switched to third_party/wayland instead of linking against Wayland from Nixpkgs (26aadca). See also f9d9864 and d932886 for more details. We could alternatively provide libffi_pic.a for static linking but due to our immutable dependency model / pure builds the dynamic linking shouldn't cause any issues. This fixes the build error shown in [0]. [0]: NixOS#213862 (comment)

primeos mentioned this issue Jan 31, 2023

Cannot build chromiumDev #195631

Closed

primeos mentioned this issue Jan 31, 2023

chromiumBeta: Fix the patch phase #213865

Merged

13 tasks

primeos closed this as completed in #213865 Jan 31, 2023

primeos reopened this Feb 1, 2023

primeos mentioned this issue Feb 6, 2023

chromiumBeta: Fix the build #215011

Merged

13 tasks

This was referenced Mar 11, 2023

chromiumDev: 112.0.5615.20 -> 113.0.5638.0 #220389

Merged

Chromium needs new/additional maintainers #197609

Open

primeos mentioned this issue Mar 31, 2023

request: add llvmPackages_16 #221736

Closed

LeFroid mentioned this issue May 6, 2023

www-client/ungoogled-chromium-113.0.5672.63_p1: Build failure with clang 15, libc++ PF4Public/gentoo-overlay#222

Closed

primeos mentioned this issue May 30, 2023

chromiumBeta: Fix the build with LLVM 16 by reverting a commit #235053

Merged

12 tasks

emilylange mentioned this issue Dec 6, 2023

Electron updates #271677

Merged

13 tasks

tomodachi94 added the 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems label May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chromium maintenance #213862

Chromium maintenance #213862

primeos commented Jan 31, 2023 •

edited

Loading

primeos commented Jan 31, 2023

primeos commented Jan 31, 2023 •

edited

Loading

primeos commented Feb 1, 2023

CyborgPotato commented Feb 4, 2023

primeos commented Feb 6, 2023

primeos commented Feb 6, 2023

primeos commented Mar 11, 2023

lorenz commented Mar 11, 2023 •

edited

Loading

RaitoBezarius commented Mar 11, 2023

RaitoBezarius commented Mar 26, 2023

primeos commented Mar 31, 2023

primeos commented May 9, 2023

RaitoBezarius commented May 10, 2023

primeos commented May 10, 2023

lorenz commented May 10, 2023

alyssais commented May 11, 2023

primeos commented Jun 13, 2023

lorenz commented Jul 12, 2023

lorenz commented Jul 13, 2023

lorenz commented Jul 13, 2023

yu-re-ka commented Dec 5, 2023

yu-re-ka commented Dec 6, 2023 •

edited

Loading

Chromium maintenance #213862

Chromium maintenance #213862

Comments

primeos commented Jan 31, 2023 • edited Loading

primeos commented Jan 31, 2023

primeos commented Jan 31, 2023 • edited Loading

primeos commented Feb 1, 2023

CyborgPotato commented Feb 4, 2023

primeos commented Feb 6, 2023

primeos commented Feb 6, 2023

primeos commented Mar 11, 2023

lorenz commented Mar 11, 2023 • edited Loading

RaitoBezarius commented Mar 11, 2023

RaitoBezarius commented Mar 26, 2023

primeos commented Mar 31, 2023

primeos commented May 9, 2023

RaitoBezarius commented May 10, 2023

primeos commented May 10, 2023

lorenz commented May 10, 2023

alyssais commented May 11, 2023

primeos commented Jun 13, 2023

lorenz commented Jul 12, 2023

lorenz commented Jul 13, 2023

lorenz commented Jul 13, 2023

yu-re-ka commented Dec 5, 2023

yu-re-ka commented Dec 6, 2023 • edited Loading

primeos commented Jan 31, 2023 •

edited

Loading

primeos commented Jan 31, 2023 •

edited

Loading

lorenz commented Mar 11, 2023 •

edited

Loading

yu-re-ka commented Dec 6, 2023 •

edited

Loading