Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden state with vim_configurable package #220

Closed
Davorak opened this issue Dec 17, 2012 · 4 comments · Fixed by #43156
Closed

Hidden state with vim_configurable package #220

Davorak opened this issue Dec 17, 2012 · 4 comments · Fixed by #43156
Assignees

Comments

@Davorak
Copy link
Contributor

Davorak commented Dec 17, 2012

What I expected:
I installed vim_configurable and I should have expected python to work arrording shlevy it is on by default.

What I got:
What I got was pythong did not work either :python print "hi" or plugins that needed python.

What I expected:
After getting python working by adding vim.python=true; to .nixpkgs/config.nix. I expected removing vim.python=true; would remove vim's access to python after nix-env -i vim_configurable.

What I got:
Vim still had access to python.

The step below demonstrate the above and an additional difference between my nixos 1.1pre2714... and nix 1.1 on ubuntu.

Nixpkgs "remembers" vim.python=true; after it is removed form .nixpkgs/config.nix

Reproduced in NixOS on VMware and nix on Ubuntu:
Each invocation of vim happens in a new shell created after the nix-env install is finished.

  • nix-env -i vim_configurable.
    ** Vim can not access python test by :python print "Hi" in vim. Should result in error.
  • Add vim.python=true; to .nixpkgs/config.nix
  • nix-env -i vim_configurable.
    ** Vim can now access python test by :python print "Hi" in vim.
  • nix-env -e vim_configurable.
  • Remove vim.python-true; in .nixpkgs/config.nix
  • nix-env -i vim_configurable
    ** Vim can still access python test by :python print "Hi" in vim.
  • Add vim.python=false; to .nixpkgs/config.nix
  • nix-env -i vim_configurable.
    ** Vim can not access python test by :python print "Hi" in vim. -> "Sorry, the command is not available in this version
  • remove vim.python=false; in .nixpkgs/config.nix
  • nix-env -i vim_configurable.
    ** :python print "Hi" in vim. ->
    (ubuntu nix 1.0: vim crashes and gives error report)
    (nixos 1.1pre2714_2f3f413: vim has acces to python)
  • Add vim.python=true; to .nixpkgs/config.nix
  • nix-env -i vim_configurable.
    ** :python print "Hi" in vim. ->
    (ubuntu nix 1.0: vim crashes and gives error report)
    (nixos 1.1pre2714_2f3f413: vim has acces to python)

There is some some state that is saved in-between installs which seems undesirable.

@shlevy
Copy link
Member

shlevy commented Dec 17, 2012

There's something strange happening here, but I don't think it's due to vim.python (and it's definitely not due to nixpkgs config being saved somewhere). https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/vim/configurable.nix#L49 has: pythonSupport = config.vim.python or true;, which means that if vim.python is not set it defaults to true. Perhaps vim_configurable needs some other flag for python support to be on? @MarcWeber ?

I'll try to reproduce this later.

@ghost ghost assigned shlevy Dec 17, 2012
@Davorak
Copy link
Contributor Author

Davorak commented Dec 17, 2012

I will document here as I did on irc that I could not get my test of :python print "hi", or a pandoc extension that called on python, to work before either adding "python" to the flags in all-packages or setting vim.python=true; in .nixpkgs/config.nix. on nixos 1.1pre2714... or on my ubuntu nix 1.1 install.

@shlevy
Copy link
Member

shlevy commented Mar 9, 2013

@Davorak Do I remember correctly that we resolved this?

@Davorak
Copy link
Contributor Author

Davorak commented Mar 9, 2013

The symptom has been resolved with this merge:

#218

There is still probably an under lying problem/issue. I don't know if it is
worth keeping open though.

On Fri, Mar 8, 2013 at 6:39 PM, Shea Levy notifications@github.com wrote:

@Davorak https://github.com/Davorak Do I remember correctly that we
resolved this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/220#issuecomment-14654262
.

Patrick Wheeler
Patrick.John.Wheeler@gmail.com
Patrick.J.Wheeler@rice.edu
Patrick.Wheeler@colorado.edu

r-ryantm pushed a commit to r-ryantm/nixpkgs that referenced this issue Jul 7, 2018
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/sysbench/versions.

<details><summary>Version release notes (from GitHub)</summary>
	* version 1.0.15
	* CI/build/packaging: add Fedora 28
	* CI/build/packaging: add Ubuntu Bionic
	* CI/build/packaging: remove Fedora 26 (EOL)
	* CI/build/packaging: remove Debian Wheezy (EOL)
	* fileio: fix NixOSGH-229 (--file-fsync-freq=0 seems to prevent
	fsync() at the end of the test)
	* command line: improve parsing of boolean command line options
	* tests: fix NixOSGH-220 (Testsuite api_sql_mysql.t failed ...)
	* tests: fix NixOSGH-223 (test failure on ppc64)
	* tests: fix opt_help.t to pass when the binary is not
	configured with MySQL support
	* MySQL driver: use it by default in DB benchmarks
</details>

These checks were done:

- built on NixOS
- /nix/store/jfyhnvp5696s1cjn64fxp5ir072m7h35-sysbench-1.0.15/bin/sysbench passed the binary check.
- 1 of 1 passed binary check by having a zero exit code.
- 1 of 1 passed binary check by having the new version present in output.
- found 1.0.15 with grep in /nix/store/jfyhnvp5696s1cjn64fxp5ir072m7h35-sysbench-1.0.15
- directory tree listing: https://gist.github.com/2d15615806f49f153b03e6495af3654b
- du listing: https://gist.github.com/6d323aaf15bf22506caed9176fe9b034
ethancedwards8 pushed a commit to ethancedwards8/nixpkgs that referenced this issue Apr 2, 2021
infinixbot pushed a commit to infinixbot/nixpkgs that referenced this issue Jul 12, 2024
…empotency

Format using the base commit from nixfmt PR 215: NixOS/nixfmt@83de1ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants