Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken font rendering on unstable #222805

Closed
RaitoBezarius opened this issue Mar 23, 2023 · 0 comments
Closed

Broken font rendering on unstable #222805

RaitoBezarius opened this issue Mar 23, 2023 · 0 comments

Comments

@RaitoBezarius
Copy link
Member

Summary : It is known that since #194594 landed on nixos-unstable channels, font rendering have been severely degraded in certain contexts for those who have the option hardware.video.hidpi.enable = lib.mkDefault true; generated by default by nixos-generate-config with a strange-looking logic which made the heuristic that a ≥ 1920 width screen was HiDPI. To fix the situation, remove hardware.video.hidpi.enable = lib.mkDefault true; and adjust whatever you need from fontconfig options by reading the documentation or using your desktop environment.

Details & Solutions

I am responsible for merging this change and causing many pain for everyone, I apologize for this.

After many discussions, we notice that those whole behaviors are just ticking bomb problems, no one can get to a proper definition of "high DPI" (see Android), neither we do possess the adequate information to adjust correctly the look'n'feel without the integer DPI information and probably other things which depend on the physical position. Therefore, "HiDPI configuration" introduced by #12345 was decided to be reverted completely through PRs #222236 #222689.

From now on, it is probably better to provide documentation and let users decide for themselves the exact set of configuration they want and accept fontconfig defaults.
Desktop environment will probably also provide their own replacements.

Overall, it is a change in a better direction. Again, I would like to remind that unstable is a place to get those changes on a population and detect any issues, this was the case and it served correctly its purpose. The situation takes time to get sorted out because there is a pile of unfortunate events which were unveiled during the fallout. It is not easy to write VM tests for font rendering, if you know how to do so, please, by all means, get involved and help us make it even better for everyone even on unstable.

In the meantime, there is no easy way to convey such information to users except discourse link or pinned issues or discussion in Matrix channels. This can probably be improved in the future.

Fix

Remove hardware.video.hidpi.enable = lib.mkDefault true; and adjust your fontconfig options according to your personal taste.

@RaitoBezarius RaitoBezarius pinned this issue Mar 23, 2023
tvlbot pushed a commit to tvlfyi/tvix that referenced this issue Mar 27, 2023
* //users/wpcarro/avaSystem: disable hidpi

  Recent changes have made nixpkgs adopt the position that hidpi
  optimization can't be done generically and at the very least needs to
  know a specific DPI number to optimize for. In addition to knowledge
  of the display(s) in question (i.e. wpcarro needs to do this) the
  issue <NixOS/nixpkgs#222805> can give
  guidance as to how to restore the desired hidpi look and feel.

Change-Id: Ia4b079a06dcb710050619f350cd0655216b4a42f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8345
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: wpcarro <wpcarro@gmail.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
tazjin pushed a commit to tvlfyi/kit that referenced this issue Mar 28, 2023
* //users/wpcarro/avaSystem: disable hidpi

  Recent changes have made nixpkgs adopt the position that hidpi
  optimization can't be done generically and at the very least needs to
  know a specific DPI number to optimize for. In addition to knowledge
  of the display(s) in question (i.e. wpcarro needs to do this) the
  issue <NixOS/nixpkgs#222805> can give
  guidance as to how to restore the desired hidpi look and feel.

Change-Id: Ia4b079a06dcb710050619f350cd0655216b4a42f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8345
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: wpcarro <wpcarro@gmail.com>
Reviewed-by: tazjin <tazjin@tvl.su>
Tested-by: BuildkiteCI
@SuperSandro2000 SuperSandro2000 unpinned this issue Mar 29, 2023
nhamlh added a commit to nhamlh/nix that referenced this issue Apr 1, 2023
nhamlh added a commit to nhamlh/nix that referenced this issue Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant