Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Haproxy with Lua support #23806

Closed
fuzzy-id opened this issue Mar 12, 2017 · 3 comments
Closed

Provide Haproxy with Lua support #23806

fuzzy-id opened this issue Mar 12, 2017 · 3 comments

Comments

@fuzzy-id
Copy link
Contributor

Issue description

At the moment Haproxy is built without the support of external Lua scripts. I managed to build a Haproxy with Lua support with the following config:

nixpkgs.config.packageOverrides = pkgs : rec {
  haproxy = pkgs.haproxy.overrideDerivation (oldAttrs : {
    buildInputs = oldAttrs.buildInputs ++ [pkgs.lua5_3];
    preConfigure = oldAttrs.preConfigure + ''makeFlags+=" USE_LUA=yes LUA_LIB=${pkgs.lua5_3}/lib LUA_INC=${pkgs.lua5_3}/include"'';
  });
};

Is there interest in having Haproxy with Lua support in nixpkgs? If so, I would like to contribute this as it seems like a nice first-starter.

Technical details

  • System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)

16.09.1829.c88e67d (Flounder)

  • Nix version: (run nix-env --version)

nix-env (Nix) 1.11.7

  • Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

"16.09.1829.c88e67d"

@Mic92
Copy link
Member

Mic92 commented Mar 12, 2017

I have no concerns and it seems to be also adopted by other downstream distributions.

@0xABAB
Copy link
Contributor

0xABAB commented Mar 12, 2017

The solution I would like to see in general is to by default include all dependencies (or alternatively those used by popular distributions), but allow flags to be passed to disable features.

This way it's possible to first get something working and then in production disable unneeded features.

fuzzy-id pushed a commit to fuzzy-id/nixpkgs that referenced this issue Mar 14, 2017
LnL7 pushed a commit to LnL7/nixpkgs that referenced this issue Mar 16, 2017
@fuzzy-id
Copy link
Contributor Author

Implemented by #24380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants