Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sddm has cmake in its runtime closure #24126

Closed
edolstra opened this issue Mar 20, 2017 · 1 comment
Closed

sddm has cmake in its runtime closure #24126

edolstra opened this issue Mar 20, 2017 · 1 comment

Comments

@edolstra
Copy link
Member

Issue description

On NixOS 17.03, the sddm in the system configuration with Plasma 5 enabled, has cmake and extra-cmake-modules in its runtime closure, which causes unnecessary bloat. This is because nixos/modules/services/x11/desktop-managers/plasma5.nix has:

      services.xserver.displayManager.sddm = {
        theme = "breeze";
        themes = [
          pkgs.extra-cmake-modules # for the setup-hook          

makeQtWrapper then causes the share directories of cmake and extra-cmake-modules to be added to the sddm wrapper script. (Automatically adding everything with a share directory to the wrapper seems pretty drastic BTW.)

@ttuegel

Technical details

  • System: NixOS 17.03.git.5ea3986
  • Nix version: 1.12pre5073_1cf4801
@ttuegel
Copy link
Member

ttuegel commented Mar 20, 2017

Automatically adding everything with a share directory to the wrapper seems pretty drastic BTW.

KDE upstream is slightly careless about implicit runtime dependencies. I spent hours trying to figure out which runtime dependencies needed to be in XDG_DATA_DIRS. By the way, you have to guess at this because SDDM doesn't log error messages. 🙄

Could we drop extra-cmake-modules? Probably. Can I answer that question for any of the other dependencies? Not a chance. So I nuked it from orbit. Guessing the correct XDG_DATA_DIRS setting would be a good project for a first-time contributor with a lot of free time.

At the moment, I'm trying to get rid of makeQtWrapper entirely. This problem may go away as a happy accident, but that won't help this release. I'm open to other suggestions.

ttuegel added a commit that referenced this issue Mar 22, 2017
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants