Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization of "altcoins" #25025

Closed
chris-martin opened this issue Apr 19, 2017 · 7 comments · Fixed by #67687
Closed

Reorganization of "altcoins" #25025

chris-martin opened this issue Apr 19, 2017 · 7 comments · Fixed by #67687

Comments

@chris-martin
Copy link
Contributor

chris-martin commented Apr 19, 2017

It looks like the "altcoins" set originated as a set of Bitcoin derivations with slightly different parameters, but eventually started to contain a bunch of cryptocurrency-related things.

People (myself included) end up submitting patches like this one with a useless layer of indirection:

  • pkgs/applications/altcoins/default.nix

    ethrun = callPackage ./ethrun.nix { };
    
  • pkgs/top-level/all-packages.nix

    ethrun = self.altcoins.ethrun;
    

Also the name is rather a misnomer. There are some cryptocurrency-related tools in here (or not in here yet but that belong grouped with these packages), not just the "coin" nodes themselves. And I believe some would vehemently disagree with the classification of Ethereum as an "altcoin".

So I propose we:

  • Rename pkgs/applications/altcoins to pkgs/applications/cryptocurrency
  • Move everything from pkgs/applications/altcoins/default.nix into pkgs/top-level/all-packages.nix
  • Move various packages into pkgs/applications/cryptocurrency:
    • pkgs/tools/misc/libbitcoin - includes the bx command-line tool for Bitcoin-related things
    • pkgs/applications/misc/qtbitcointrader - Bitcoin trading client
    • pkgs/tools/security/secp256k1 - technically isn't specifically cryptocurrency-related, but it's the elliptic curve popularized by Bitcoin and the library is maintained by bitcoin-core
    • pkgs/servers/trezord - daemon for using a Bitcoin hardware wallet
    • pkgs/applications/misc/vanitygen - a Bitcoin vanity address generator
    • pkgs/applications/misc/electrum - a Bitcoin wallet
    • pkgs/applications/misc/cgminer - a Bitcoin GPU miner
@matthewbauer
Copy link
Member

matthewbauer commented Apr 19, 2017

Sounds pretty reasonable. We do have the related problem that all-packages.nix has gotten really huge. I don't know of a good solution to it but probably we'll need to split up in some way. Anyway, I don't think 10-20 extra lines is going to make anything much worse.

I do find the naming of some of the directories a little hard to remember. For instance games go in pkgs/games, but emulators go in pkgs/misc/emulators. Both emulators and games are almost always considered "applications" but they don't live in pkgs/applications even though we even have a directory names pkgs/applications/misc. Does anyone know of any standard for directory names in nixpkgs? I couldn't find anything.

@chris-martin
Copy link
Contributor Author

chris-martin commented Apr 19, 2017

@matthewbauer I also have thoughts on the larger organization problem, but I'm hoping to keep the scope of this issue more narrow :)

@MDeltaX
Copy link

MDeltaX commented May 16, 2017

I suggest renaming it to "blockchain" or "blockchains" instead of "cryptocurrency", since not every blockchain is used as a currency and I see no reason to differentiate currencies from non-currencies.

@chris-martin
Copy link
Contributor Author

I can agree with that, yeah. The meaning of "blockchain" has gotten a bit overloaded but I think it's the word most people will associate with this category of software.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Are there any updates on this issue, please?

@jb55
Copy link
Contributor

jb55 commented Aug 24, 2019

ACK, I get triggered evertime I see altcoins.bitcoin or altcoins.clightning

we should just do away with the attrset entirly and just categorize it like everthing else in nixpkgs, in a specific folder like blockchains or databases?

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@jb55 +1 for blockchains, I guess that technology will only grow.

jb55 added a commit to jb55/nixpkgs that referenced this issue Sep 1, 2019
Release notes for NixOS#67687 (bc08b42) [1]
Related issue: NixOS#25025 [2]

[1] NixOS#67687
[2] NixOS#25025

Suggested-by: @mmahut
Signed-off-by: William Casarin <jb55@jb55.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants