Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put apple-source-releases in Hydra #25200

Closed
matthewbauer opened this issue Apr 25, 2017 · 5 comments
Closed

Put apple-source-releases in Hydra #25200

matthewbauer opened this issue Apr 25, 2017 · 5 comments
Labels
6.topic: darwin Running or building packages on Darwin

Comments

@matthewbauer
Copy link
Member

I just realized that a few of my apple open source derivations are broken (developer_cmds, network_cmds, etc.) I wanted to find the first point they failed but can't because they aren't in the Hydra job set. Maybe we can change this for everything in Darwin.*?

Cc @copumpkin
@FRidh FRidh added the 6.topic: darwin Running or building packages on Darwin label Apr 25, 2017
@LnL7
Copy link
Member

LnL7 commented May 17, 2017

I noticed the same for iterm2. But it's not clear to me why that one is ignored, it's a top level attribute and has a license.

@matthewbauer
Copy link
Member Author

@LnL7 I'm wondering if something else is going on here. Maybe Hydra isn't working right with derivations that are darwin only? I've had a similar issue with another top level derivation like that.

@LnL7
Copy link
Member

LnL7 commented May 19, 2017

You're right, I think darwin only jobs are just not showing up. I thought it was related to meta.license.

@LnL7
Copy link
Member

LnL7 commented May 19, 2017

I see what's going on now. pkgsFor "x86_64-linux" is used to discover the platforms here https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/release-lib.nix#L96, but a darwin only drv won't evaluate.

I think #22277 would fix this.

@LnL7 LnL7 mentioned this issue May 19, 2017
Closed
1 task
@matthewbauer matthewbauer mentioned this issue Aug 11, 2017
Merged
@FRidh
Copy link
Member

FRidh commented Aug 12, 2017 •
edited

The function you refer to creates a set with attribute, platform pairs. Your example iterm2 has meta.platforms specified, so I don't see how that piece of code is relevant. The functions applePackage and appleDerivation don't seem to be setting any meta at all so I think that's best fixed instead of using the solution from #25930.

matthewbauer pushed a commit to matthewbauer/nixpkgs that referenced this issue Aug 13, 2017
@dezgeg @matthewbauer
nixpkgs release: Fix Darwin-only jobs
3e9f767 
Currently the logic of generating nixpkgs Hydra jobs is to walk through
the pkgs evaluated for system = "x86_64-linux", collect any derivations
and their meta.platforms values. However, that doesn't work for
packages whose meta.platforms doesn't include x86_64-linux, as just
evaluating their meta attribute raises an error so they get skipped
completely.

As a less-intrusive fix (i.e. anything than rewriting the current package
enumeration logic), allow passing `config.allowUnsupportedSystem = true`
to permit evaluating packages regardless of their platform and use that
in the package listing phase.

Fixes NixOS#25200
@LnL7 LnL7 closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable hydra jobs for some of the darwin only packages LnL7/nixpkgs
3 participants
@matthewbauer @LnL7 @FRidh