Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify: add libGL #272152

Merged
merged 1 commit into from
Dec 10, 2023
Merged

spotify: add libGL #272152

merged 1 commit into from
Dec 10, 2023

Conversation

Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Dec 4, 2023

Description of changes

Fixes error spam:

ERR: Display.cpp:1066 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
ERR: Display.cpp:1066 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
ERR: Display.cpp:1066 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory
ERR: Display.cpp:1066 (initialize): ANGLE Display::initialize error 12289: Could not dlopen libGL.so.1: libGL.so.1: cannot open shared object file: No such file or directory

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gerg-L Gerg-L changed the title spotify: add libglnvd spotify: add libglvnd Dec 4, 2023
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Dec 4, 2023

typo

@NickCao
Copy link
Member

NickCao commented Dec 5, 2023

I believe we should add libGL instead of libglvnd, maybe the respective maintainers can also provide some opinions. cc @primeos @vcunat

@Gerg-L Gerg-L changed the title spotify: add libglvnd spotify: add libGL Dec 6, 2023
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Dec 6, 2023

switched to libGL

@Gerg-L Gerg-L requested a review from NickCao December 10, 2023 22:12
@NickCao NickCao merged commit e52f0b9 into NixOS:master Dec 10, 2023
23 checks passed
@Gerg-L Gerg-L deleted the spotify branch December 10, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants