opendht: init at 1.3.4 #27306
Merged
opendht: init at 1.3.4 #27306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 11, 2017
| description = "A C++11 Kademlia distributed hash table implementation"; | ||
| homepage = https://github.com/savoirfairelinux/opendht; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ taeer olynch ]; |
There was a problem hiding this comment.
There is no olynch in lib/maintainers.nix.
There was a problem hiding this comment.
olynch is there:
https://github.com/NixOS/nixpkgs/blob/master/lib/maintainers.nix#L413
I added him here: 06e701a
I am Taeer, and owen and I made this package together. He agrees to be added as maintainer.
There was a problem hiding this comment.
ok, then my nixpkgs was not up to date.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
needed for ring-daemon
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)