Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcom-STA failed to build on linux kernel > 4.9 & nixos 17.03 #27607

Closed
Shamash2014 opened this issue Jul 24, 2017 · 2 comments
Closed

Broadcom-STA failed to build on linux kernel > 4.9 & nixos 17.03 #27607

Shamash2014 opened this issue Jul 24, 2017 · 2 comments
Milestone

Comments

@Shamash2014
Copy link

Shamash2014 commented Jul 24, 2017

Issue description

Broadcom-sta wifi driver failed to build on linux kernel > 4.9

Steps to reproduce

Just run nixos-rebuid switch, here is detailed stack trace:

make[1]: Entering directory '/nix/store/qidc6n9jvfzz9jik83m2dv88b7zx76yl-linux-4.12.2-dev/lib/modules/4.12.2/build'
CFG80211 API is prefered for this kernel version
Using CFG80211 API
  LD      /tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/built-in.o
  CC [M]  /tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/src/shared/linux_osl.o
  CC [M]  /tmp/nix-build-virtualbox-modules-5.1.18-4.12.2.drv-0/virtualbox-5.1.18-modsrc/vboxdrv/linux/SUPDrv-linux.o
  CC [M]  /tmp/nix-build-virtualbox-modules-5.1.18-4.12.2.drv-0/virtualbox-5.1.18-modsrc/vboxdrv/SUPDrv.o
  CC [M]  /tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/src/wl/sys/wl_linux.o
/tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/src/wl/sys/wl_linux.c: In function 'wl_monitor':
/tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/src/wl/sys/wl_linux.c:2920:10: error: 'struct net_device' has no member named 'last_rx'
  skb->dev->last_rx = jiffies;
          ^
make[4]: *** [/nix/store/qidc6n9jvfzz9jik83m2dv88b7zx76yl-linux-4.12.2-dev/lib/modules/4.12.2/source/scripts/Makefile.build:303: /tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta/src/wl/sys/wl_linux.o] Error 1
make[3]: *** [/nix/store/qidc6n9jvfzz9jik83m2dv88b7zx76yl-linux-4.12.2-dev/lib/modules/4.12.2/source/Makefile:1512: _module_/tmp/nix-build-broadcom-sta-6.30.223.271-4.12.2.drv-0/broadcom-sta] Error 2
make[2]: *** [Makefile:152: sub-make] Error 2
make[1]: *** [Makefile:24: __sub-make] Error 2
make[1]: Leaving directory '/nix/store/qidc6n9jvfzz9jik83m2dv88b7zx76yl-linux-4.12.2-dev/lib/modules/4.12.2/build'
make: *** [Makefile:161: all] Error 2

Hardware configuration line:

{ config, lib, pkgs, ... }:

{
  imports =
    [ <nixpkgs/nixos/modules/installer/scan/not-detected.nix>
    ];

  boot.initrd.availableKernelModules = [ "xhci_pci" "ehci_pci" "ahci" "usb_storage" "sd_mod" "rtsx_pci_sdmmc" ];
  boot.kernelModules = [ "kvm-intel" "wl" ];
  boot.extraModulePackages = [ config.boot.kernelPackages.broadcom_sta ];

  nix.maxJobs = lib.mkDefault 8;
}

Technical details

  • System: NixOS: 17.03.1584.48ecdcf598 (Gorilla)
  • Nix version: nix-env (Nix) 1.11.11
  • Nixpkgs version: 17.03.1584.48ecdcf598
  • Sandboxing enabled: true
@Shamash2014 Shamash2014 changed the title Broadcom-STA failed to build on linux kernel > 4.9 Broadcom-STA failed to build on linux kernel > 4.9 & nixos 17.03 Jul 24, 2017
@Mic92
Copy link
Member

Mic92 commented Jul 24, 2017

Probably requires some backports from master like daf6744 and c71233f (@aszlig maybe?)

@fpletz fpletz modified the milestones: 17.09, 17.03 Jul 25, 2017
fpletz pushed a commit that referenced this issue Jul 25, 2017
(cherry picked from commit daf6744)

Fixes #27607.
fpletz pushed a commit that referenced this issue Jul 25, 2017
The patch is from Arch Linux at:

https://aur.archlinux.org/cgit/aur.git/tree/linux412.patch?h=broadcom-wl

Tested this by building against the following attributes:

  * linuxPackages.broadcom_sta
  * linuxPackages_latest.broadcom_sta
  * pkgsI686Linux.linuxPackages.broadcom_sta
  * pkgsI686Linux.linuxPackages_latest.broadcom_sta

I have not tested whether this works at runtime, because I do not posess
the hardware.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>

(cherry picked from commit c71233f)

Fixes #27607.
@fpletz
Copy link
Member

fpletz commented Jul 25, 2017

Fixed by backporting those two commits and testing build.

@fpletz fpletz closed this as completed Jul 25, 2017
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
The patch is from Arch Linux at:

https://aur.archlinux.org/cgit/aur.git/tree/linux412.patch?h=broadcom-wl

Tested this by building against the following attributes:

  * linuxPackages.broadcom_sta
  * linuxPackages_latest.broadcom_sta
  * pkgsI686Linux.linuxPackages.broadcom_sta
  * pkgsI686Linux.linuxPackages_latest.broadcom_sta

I have not tested whether this works at runtime, because I do not posess
the hardware.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>

(cherry picked from commit c71233f)

Fixes NixOS#27607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants