-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update request: keybase/kbfs/keybase-gui 6.2.3 → 6.2.4 #278277
Comments
It's already on master since yesterday #278033. If I'm not mistaken, kbfs would already be fixed by the above. But keybase-gui apparently downloads a binary off of AWS. |
Updated keybase-gui PR here #278346. |
(Updating` keybase and restarting kbfs fixes the recent certificate issue.) |
Will this update be backported into 23.11? |
I’ll try to fix up the patch tomorrow (unless someone beats me to it). This is indeed a pretty critical issue for people who use keybase on daily basis. |
@eyeinsky did you verify that kbfs is working properly, and that the kbfsfuse is suddenly failing to mount my kbfs directory on all of my systems. the error message that shows up in the logs when the service fails to start is i've been able to fix it by copying the service from nixpks into my own configs and commenting out the |
@kf5grd kbfs doesn't seem to work for me either :/ |
It looks like Keybase did a re-release with the same version number, tripping up the default nixpkgs.overlays = [(
self: super:
{
keybase = super.keybase.overrideAttrs ( old: rec {
pname = "keybase";
version = "6.2.4";
src = super.fetchFromGitHub {
owner = "keybase";
repo = "client";
rev = "ae7e4a1c153403106352bd2fcfa7f16d54f35974"; #"v${version}";
hash = "sha256-z7vpCUK+NU7xU9sNBlQnSy9sjXD7/m8jSRKfJAgyyN8=";
};
});
keybase-gui = super.keybase-gui.overrideAttrs ( old: rec {
pname = "keybase-gui";
version = "6.2.4";
versionSuffix = "20240101011938.ae7e4a1c15";
src = super.fetchurl {
url = "https://s3.amazonaws.com/prerelease.keybase.io/linux_binaries/deb/keybase_${version + "-" + versionSuffix}_amd64.deb";
hash = "sha256-XyGb9F83z8+OSjxOaO5k+h2qIY78ofS/ZfTXki54E5Q=";
};
});
}
)]; Specifically the default configuration has the given path has multiple possibilities: #<Git::Ref:0x00007fdfcdd38218>, #<Git::Ref:0x00007fdfcdd5c320> |
@AngryAnt Do either |
Mounting had stopped working for several weeks on my side, long before the certificate expired. I thought it was just me because there were no matching issues. |
@239 It has actually been the same for me (for me, probably even more than weeks, maybe months or so). It also seemed to depend on my nixos install -- an older install it kept working for a while, while a newer machine I had it didn't work right from the start (IIRC). |
Not sure if this is even relevant, but |
I only noticed an issue after the new year and my upgrade to 23.11, where those happened pretty close to each other. It was definitely working when I was on 23.05 immediately before Christmas as I use something which relies on the kbfs mount pretty much constantly. |
With the overlay from here: #278277 (comment) I still get a bunch of errors from kbfs.service:
The "failed to verify certificate" part would appear to be the cause. |
@seanparsons Yeah, we haven't fully figured the kbfs issue yet. If you can, please try any of the linked PRs with |
@eyeinsky I got the update to 23.11 which incorporates the update which now just gets fusermount failing with an exit status of 1. But looking at service definition it already appears to have |
Ah, it was the reverse, @kf5grd said commenting it out helped, i.e setting it to |
Is there a simple way to do so on a regular NixOS setup? |
@seanparsons, you can set:
(cc @kf5grd, this is cleaner than forking the whole module definition) |
It looks like it should be:
Which does work for whatever reason. |
Oh right, it's different between |
It seems this is fairly important as the keybase apps don't work properly now (especially kbfs it seems) because there has been a change of certificate: keybase/client#26088
@Avaq @carlsverre @np @rvolosatovs @Br1ght0ne @kf5grd
Note for maintainers: Please tag this issue in your PR.
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: