-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libstdc++: add setup-hook #28998
libstdc++: add setup-hook #28998
Conversation
@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill, @copumpkin and @vcunat to be potential reviewers. |
allowedRequisites = null; | ||
cc = self.clang; | ||
# Use the gcc libstdc++ when targeting linux. | ||
extraBuildInputs = if targetPlatform.isLinux then [ libstdcxxHook ] else drv.extraBuildInputs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps this should be stdenv.cc.isGNU
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! I do like stdenv.cc.isGNU
too.
Motivation for this change
An alternative for #28870, this should also allow us to get rid of
default_cxx_stdlib_compile
entirelyFixes #28223
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)