Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx with nginxModules.echo is broken on nixos-17.09 #29555

Closed
vaibhavsagar opened this issue Sep 19, 2017 · 3 comments · Fixed by #29633
Closed

nginx with nginxModules.echo is broken on nixos-17.09 #29555

vaibhavsagar opened this issue Sep 19, 2017 · 3 comments · Fixed by #29633

Comments

@vaibhavsagar
Copy link
Member

vaibhavsagar commented Sep 19, 2017

Issue description

As per the title, nginx with nginxModules.echo is broken on revision 670b4e29adc16e0a29aa5b4c126703dcca56aeb6

Steps to reproduce

git clone https://github.com/NixOS/nixpkgs-channels
cd nixpkgs-channels
git checkout 670b4e29adc16e0a29aa5b4c126703dcca56aeb6
nix-build -I nixpkgs=. -E "with import <nixpkgs> {}; let stable = import <nixpkgs/pkgs/servers/http/nginx/stable.nix>; in pkgs.callPackage stable { modules = [nginxModules.echo]; }"

Technical details

  • System: 17.03.1820.a0e6a891ee
  • Nix version: nix-env (Nix) 1.11.14
  • Nixpkgs version: 670b4e29adc16e0a29aa5b4c126703dcca56aeb6
  • Sandboxing enabled: no
@vaibhavsagar
Copy link
Member Author

Usually these issues are closed when a fix is committed to master, but it can still take a few days for that change to make its way to nixos-17.09. My actual issue is that I can't build nginx on 17.09, so can I ask that this remain open until that is fixed?

Mic92 pushed a commit to vaibhavsagar/nixpkgs that referenced this issue Sep 21, 2017
Mic92 pushed a commit that referenced this issue Sep 21, 2017
This fixes #29555.

(cherry picked from commit dea2aff)
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

I also added it to 17.09. I don't think there is much value in keeping the issue open, as it will be resolved automatically on the next channel update.

@vaibhavsagar
Copy link
Member Author

You're completely right, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants