-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdf5 pulls in gcc-wrapper #29889
Comments
Here |
@orivej cool, I just did that and it worked pretty well. I'll have a PR made up shortly and link to this ticket. |
The build provides as text a summary of the build, including the absolute path of the compiler used for compilation. Unfortunately, this pulls in stdenv.cc as a transitive closure. So this change just calls remove-references-to as a postInstall step for the one stdenv.cc dependency. See #29889 for details.
The build provides as text a summary of the build, including the absolute path of the compiler used for compilation. Unfortunately, this pulls in stdenv.cc as a transitive closure. So this change just calls remove-references-to as a postInstall step for the one stdenv.cc dependency. See #29889 for details. (cherry picked from commit 405c7f9e437a89bbebc3e2663e8fcc74e69783d6)
@FRidh thanks for taking care of the recommended changes (I was sleeping). I need to look up again the difference between native and normal build inputs. I still get confused about the difference. |
A fun problem found via
in installcheck phase, and this I guess nobody uses binaries this package has in nixpkgs, but having those be broken by default isn't nice, I think. I can't reopen this, but I suggest doing so and solving this by splitting the package into multiple outputs or something. |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
No longer |
Issue description
The hdf5 library pulls in gcc-wrapper as a transitive dependency, which seems less than ideal.
The problem is that the build creates this text file summary of the build in lib/libhdf5.settings, that has the following:
Additionally, this same text is embedded as a string in one of the shared libraries (lib/libhdf5.so.10.2.1).
The reason this is annoying for me is that I use transitive closures to bundle minimized tarballs, which I then put into Docker. But now gcc is grabbed, just because someone put in a informational string of which compiler was used.
I still have to go through the hdf5 source code and see if there's a simple fix. I could use the replace-literal utility to crop off the "/nix/store" from the reference in the shared library (maybe... not sure how tricky that might be). It's certainly easier to modify the libhdf5.settings file.
I'm open to other ideas.
Steps to reproduce
yields
Technical details
nixos-version
, Ubuntu/Fedora:lsb_release -a
, ...)Debian testing with Nix
nix-env --version
)nix-env (Nix) 1.11.14
nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion
)"18.03pre116475.d757d8142e"
grep build-use-sandbox /etc/nix/nix.conf
)build-use-sandbox = true
The text was updated successfully, but these errors were encountered: