[Tracking issue] remove all src = ./. entries that unintentionally include their own .nix files

[philiptaron]

Issue description

Derivations that use src = ./. will be rebuilt on any change to the .nix file that includes them, including formatting changes caused by nixfmt-rfc-style for RFC 166.

List of files where this may be the case

Generated with rg -F 'src = ./.' --sort=path -l -tnix and not very thoroughly audited. Unchecked entries need work or attention.

• doc/default.nix
• maintainers/scripts/convert-to-import-cargo-lock/default.nix (uses cleanSourceWith)
• nixos/lib/test-driver/default.nix
• pkgs/build-support/node/fetch-npm-deps/default.nix (uses cleanSourceWith)
• pkgs/build-support/release/default.nix (only in a comment)
• pkgs/build-support/rust/test/import-cargo-lock/basic/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/basic-dynamic/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/git-dependency/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/git-dependency-branch/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/git-dependency-rev/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/git-dependency-rev-non-workspace-nested-crate/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/git-dependency-tag/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/build-support/rust/test/import-cargo-lock/v1/default.nix tests.importCargoLock: fix self-inclusive src listings in .nix files #303146
• pkgs/by-name/pu/purescm/package.nix
• pkgs/by-name/pu/purescm/package.nix
• pkgs/development/compilers/ghcjs/8.10/stage0.nix
• pkgs/development/compilers/pakcs/curry-frontend.nix
• pkgs/development/compilers/reason/tests/hello/default.nix
• pkgs/development/cuda-modules/saxpy/default.nix
• pkgs/development/interpreters/python/tests/test_nix_pythonprefix/typeddep/default.nix
• pkgs/development/julia-modules/tests/julia-top-n/default.nix
• pkgs/development/libraries/nanopb/test-message-with-annotations/default.nix
• pkgs/development/libraries/nanopb/test-message-with-options/default.nix
• pkgs/development/libraries/nanopb/test-simple-proto2/default.nix
• pkgs/development/libraries/nanopb/test-simple-proto3/default.nix
• pkgs/development/libraries/science/math/libtorch/test/default.nix
• pkgs/development/libraries/science/math/mkl/test/default.nix
• pkgs/development/ocaml-modules/reason-native/tests/console/default.nix
• pkgs/development/python-modules/spacy/annotation-test/default.nix
• pkgs/development/python-modules/spacy-transformers/annotation-test/default.nix
• pkgs/development/python-modules/waitress-django/default.nix python3Packages: format with nixfmt #313628
• pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix
• pkgs/misc/documentation-highlighter/default.nix (uses cleanSourceWith)
• pkgs/servers/mx-puppet-discord/node-packages.nix
• pkgs/servers/sip/kamailio/test-kamailio-bin/default.nix kamailio: fix test src #312519
• pkgs/test/haskell/cabalSdist/local/generated.nix
• pkgs/test/haskell/setBuildTarget/default.nix
• pkgs/tools/nix/nixos-option/default.nix nixos-option: fix self inclusive src #307564 Revert "nixos-option: fix self inclusive src" #307936
• pkgs/tools/system/dell-command-configure/default.nix dell-command-configure: fix self inclusive src #307479

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-testing-nix-formatter/39179/21

[oliviacrain]

Did a quick check for false positives, found four:

Uses lib.cleanSourceWith to filter out default.nix

pkgs/build-support/node/fetch-npm-deps/default.nix
maintainers/scripts/convert-to-import-cargo-lock/default.nix
pkgs/misc/documentation-highlighter/default.nix

Found src = ./. in a comment

pkgs/build-support/release/default.nix

[philiptaron]

Thanks! I updated the listing to check those off.

[infinisil]

Note that we can use the new lib.fileset library (tutorial) to fix this now!