Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "emacsWrapper" also wrap PATH and PYTHONPATH? #30705

Closed
adisbladis opened this issue Oct 23, 2017 · 7 comments
Closed

Should "emacsWrapper" also wrap PATH and PYTHONPATH? #30705

adisbladis opened this issue Oct 23, 2017 · 7 comments
Labels
0.kind: enhancement 0.kind: question 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: community feedback

Comments

@adisbladis
Copy link
Member

adisbladis commented Oct 23, 2017

Issue description

Currently emacsWrapper wraps the $EMACSLOADPATH environment variable. I also think it would be useful to wrap other environment variables such as $PATH and $PYTHONPATH.

This would make it a whole lot easier and intuitive to work with certain modes like flycheck which checks $PATH for checkers and linters and jedi-mode which requires some python dependencies both in $PATH and $PYTHONPATH.

I want to be able to add non-elisp packages to emacsWithPackages and have things just work.

Technical details

  • System:
    18.03.git.fd3bb25895M (Impala)
  • Nix version:
    nix-env (Nix) 1.11.15
  • Nixpkgs version:
    "18.03.git.fd3bb25895M"
@peterhoeg
Copy link
Member

The problem with that approach is that we would potentially need to wrap everything in existence.

I use a combination of emacs, direnv and emacs-direnv to set up things up on a project level. Works OK so far.

@bkchr
Copy link
Contributor

bkchr commented Oct 24, 2017

I also use direnv and emacs-direnv to load all the required tools into the path for emacs. That works relative good.

@adisbladis
Copy link
Member Author

adisbladis commented Oct 24, 2017

Direnv + emac-direnv sounds like a very nice combination but it doesn't solve the core issue of making non-elisp tooling available.
I personally want to use the same tooling regardless of project setup.

@peterhoeg What makes you think you'd probably need to "wrap everything in existence"?
Are you thinking about scope creep?

@peterhoeg
Copy link
Member

Direnv + emac-direnv sounds like a very nice combination but it doesn't solve the core issue of making non-elisp tooling available.

Actually it does. It means you can have all your python stuff available in one project and haskell in another without them ever stepping on each other and the dependencies defined per project, so whoever else is working on that same project will have everything available as well.

I personally want to use the same tooling regardless of project setup.

For some things, sure. So you wrap what you need - I don't think we can decide on what everybody needs which is the problem.

@lukateras
Copy link
Member

I'd like emacsWithPackages to wrap $PATH, too.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@adisbladis
Copy link
Member Author

I've since been convinced that wrapping $PATH is the wrong thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement 0.kind: question 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: community feedback
Projects
None yet
Development

No branches or pull requests

5 participants