Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: prisma-engines 5.12.1 → 5.14.0 #314615

Open
1 task done
musjj opened this issue May 25, 2024 · 3 comments
Open
1 task done

Update request: prisma-engines 5.12.1 → 5.14.0 #314615

musjj opened this issue May 25, 2024 · 3 comments

Comments

@musjj
Copy link
Contributor

musjj commented May 25, 2024

  • Current version on the unstable channel: 5.12.1
  • Current version on the stable/release channel: 5.4.1

Notify maintainers

@pimeys @tomhoule @ivan @aqrln

There's a new createManyAndReturn() function that I really sorely need, would appreciate if it can be updated.


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@aqrln
Copy link
Member

aqrln commented May 25, 2024

I can open a PR to update it but be aware that it will likely be rejected as it is or will take a while to merge. Updating the engines and Prisma CLI must happen in lockstep, and while the former is easy and uncontroversial, the latter is problematic and has been stalling the regular updates for quite some time already.

There's a consensus that nodePackages are being phased out and new and updated packages need to be moved out of there and be built with buildNpmPackage, which doesn't quite work for Prisma because of pnpm. I'm yet to try throwing out the pnpm lockfile and installing the dependencies with npm, as it was suggested the last time (and as other pnpm based projects are currently being built in nixpkgs), and I'm even not as opposed to this idea anymore as previously: the CLI actually has a pretty high chance of working with the wrong versions of dependencies (I wouldn't trust the client though). That said, I suspect further problems down the road given the complex build process of Prisma's TS codebase. Any help would be appreciated.

@musjj
Copy link
Contributor Author

musjj commented May 25, 2024

I see, thanks for the info.

For now I'm using this awesome flake: https://github.com/VanCoding/nix-prisma-utils, it's a real life-saver. It fetches the pre-built binaries from upstream that matches with your package-lock.json and patches them for Nix. The only downside is that you need to manually update the hashes.

@aqrln
Copy link
Member

aqrln commented May 25, 2024

https://github.com/VanCoding/nix-prisma-utils is great, yes. In my opinion, this is actually a much better solution for typical development workflows involving Prisma than relying on prisma-engines from nixpkgs without any guarantees that it matches the version of Prisma you depend on in a specific project. The fact that it now exists is why I haven't felt too much pressure to refactor and update the packages here.

I also have a work-in-progress proof of concept of just supporting NixOS out of the box for local development in Prisma which would make using prisma-engines from nixpkgs only necessary if you were to package your own application with Nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants