-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harvid: 0.9.0 -> 0.9.1; tidy up #331558
harvid: 0.9.0 -> 0.9.1; tidy up #331558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emilazy 🙏
I checked linux ✔️ then and also checked apple darwin with:
NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix shell --impure github:emilazy/nixpkgs/push-xlsnptznlrsl#harvid
and it seems to work nicely too!
> harvid --help ~
harvid - http ardour video server
Usage: harvid [OPTION] [document-root]
# ...
> nix-info -m ~
- system: `"aarch64-darwin"`
- host os: `Darwin 22.5.0, macOS 13.4.1`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.21.0`
- channels(root): `"nixpkgs"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
Will leave it up to you on whether or not to add the system though 👍
d751486
to
0793d3e
Compare
Oh, oops, I dropped the |
Description of changes
Includes fixes for FFmpeg ≥ 5 and parallel building. I also made it work on macOS.
Result of
nixpkgs-review
run on aarch64-linux 11 package failed to build:
2 packages built:
The
ardour_7
failure seems unrelated, as it is already broken on Hydra.Diff: x42/harvid@v0.9.0...v0.9.1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.