-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim plugin "LanguageClient-neovim" seems to miss dependencies #33391
Comments
This wont be that simple. |
Ok. I tried adding the missing packages to my "vim-hug-neovim-rpc" = buildVimPlugin {
name = "vim-hug-neovim-rpc";
src = fetchgit {
url = "https://github.com/roxma/vim-hug-neovim-rpc";
rev = "60093847f0ba0a57ace54df30bd17a8239a99d6f";
sha256 = "0rim73si32z1h9rh0i2qs5gy010cpb6mz1zxr197agf85zdq7x0f";
};
dependencies = [];
pythonDependencies = with pkgs.python3Packages; [ neovim ];
};
"nvim-yarp" = buildVimPlugin {
name = "nvim-yarp";
src = fetchgit {
url = "https://github.com/roxma/nvim-yarp";
rev = "b222af8dbbfb35c6d833fd76a940f6ca2fe322fa";
sha256 = "0rialn5xmyd3n02j81cflvljrx2lld2mhggni66frrjdz5c45xkl";
};
dependencies = [];
pythonDependencies = with pkgs.python3Packages; [ neovim ];
}; and import them into my pluginDictionaries = [
/* others */
{ name = "LanguageClient-neovim"; }
{ name = "nvim-yarp"; }
{ name = "vim-hug-neovim-rpc"; }
]; But when firing up
|
Here's a working expression:
I think probably buildVimPlugin and/or buildRustPackage should be refactored so they can be combined more easily. |
I also had a try at getting this to work {
LanguageClient-neovim =
let
LanguageClient-neovim-src = fetchgit {
url = "https://github.com/autozimu/LanguageClient-neovim";
rev = "fbc46862af7fa254f74f1108149fd0669c46f1ad";
sha256 = "1wrrmikriyw8an8hn7240igcaca9a0ykh1j0dfy45kslxkmqkk3r";
};
LanguageClient-neovim-bin = rustPlatform.buildRustPackage {
name = "LanguageClient-neovim-bin";
src = LanguageClient-neovim-src;
cargoSha256 = "0c2sklpvab63a1f1mhcq9abq5m2srkj52ypq7dq44g8ngn2a05ka";
};
in buildVimPluginFrom2Nix { # created by nix#NixDerivation
name = "LanguageClient-neovim-2018-03-06";
src = LanguageClient-neovim-src;
dependencies = [];
propogatedBuildInputs = [ LanguageClient-neovim-bin ];
preFixup = ''
substituteInPlace "$out"/share/vim-plugins/LanguageClient-neovim/plugin/LanguageClient.vim \
--replace "let l:command = [s:root . '/bin/languageclient']" "let l:command = ['${LanguageClient-neovim-bin}/bin/languageclient']"
'';
};
} I couldn't see a way to make it look reasonable as a patch for |
@johnchildren I think it is ok for some complicated plugins to just be done manually. Make sure to put it above |
Following up from issue NixOS#33391, building LanguageClient-neovim now requires some rust dependencies. This patch makes the plugin now longer listed in vim-plugin-names file so that it will not be automatically generated and instead lists it in non-generated plugins. Also adds rustPlatform to arguments for vim plugins set.
#36829 hopefully contains the requested changes. edit: I don't know if this actually addresses the original issue though. |
@matthiasbeyer you maybe have time to check if LanguageClient-neovim works for you now, since we merged #36856? |
Following up from issue NixOS#33391, building LanguageClient-neovim now requires some rust dependencies. This patch makes the plugin now longer listed in vim-plugin-names file so that it will not be automatically generated and instead lists it in non-generated plugins. Also adds rustPlatform to arguments for vim plugins set.
@garbas I'd love to. Unfortunately, because I bake vim directly into Is there a way to build only one package from Am trying with
and |
The above fails:
With master at 669cbb6 |
Cargo-culted with This results in a vim which does not print the error messages from this issue anymore. Will now do more tests. |
I just renamed a function with RLS! Seems to work 🎉 |
Following up from issue #33391, building LanguageClient-neovim now requires some rust dependencies. This patch makes the plugin now longer listed in vim-plugin-names file so that it will not be automatically generated and instead lists it in non-generated plugins. Also adds rustPlatform to arguments for vim plugins set.
Issue description
The vim plugin "LanguageClient-neovim" seems to miss a dependency, when installing it via configuration.nix, vim starts with warnings:
See also
It seems these are not yet packaged in nixpkgs.
Steps to reproduce
Install
{ name = "LanguageClient-neovim"; }
in vim customization, then start vim after rebuilding.Technical details
"x86_64-linux"
Linux 4.14.5, NixOS, 18.03pre124015.f59a0f7f1a6 (Impala)
yes
yes
nix-env (Nix) 1.11.16
"nixos-18.03pre124015.f59a0f7f1a6"
""
/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs
The text was updated successfully, but these errors were encountered: