pytest-flake8: checkPhase failure

[ckauhaus]

Issue description

python36Packages.pytest-flake8 fails to build as of e821f40 on both Linux and Darwin: failed assertion

Steps to reproduce

$ nix-build -A pkgs.python36Packages.pytest-flake8

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /build/pytest-flake8-1.0.0, inifile: tox.ini
plugins: flake8-1.0.0
collected 15 items

pytest_flake8.py .                                                       [  6%]
setup.py .                                                               [ 13%]
test_flake8.py ...........xF                                             [100%]

=================================== FAILURES ===================================
_____________________________ test_junit_classname _____________________________

testdir = <Testdir local('/build/pytest-of-nixbld/pytest-0/test_junit_classname0')>

    def test_junit_classname(testdir):
        testdir.makepyfile("")
        result = testdir.runpytest("--flake8", "--junit-xml=TEST.xml")
        junit = testdir.tmpdir.join("TEST.xml")
        with open(str(junit)) as j_file:
            j_text = j_file.read()
        assert result.ret == 0
>       assert 'classname=""' not in j_text
E       assert 'classname=""' not in '<?xml version="1.0" encoding="utf-8"?><testsuite errors="0" failures="0" name="pytest" skips="0" tests="1" time="0.12...ile="test_junit_classname.py" line="-1" name="test_junit_classname" time="0.11568927764892578"></testcase></testsuite>'

/build/pytest-flake8-1.0.0/test_flake8.py:188: AssertionError
----------------------------- Captured stdout call -----------------------------
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /build/pytest-of-nixbld/pytest-0/test_junit_classname0, inifile:
plugins: flake8-1.0.0
collected 1 item

test_junit_classname.py .                                                [100%]

 generated xml file: /build/pytest-of-nixbld/pytest-0/test_junit_classname0/TEST.xml
=========================== 1 passed in 0.12 seconds ===========================
================ 1 failed, 13 passed, 1 xfailed in 2.36 seconds ================
builder for '/nix/store/nkffrk37xmg7lnnzvgz9jp9rlf8ax1fa-python3.6-pytest-flake8-1.0.0.drv' failed with exit code 1

Same of python35Packages.pytest-flake8 on both Linux and Darwin.

Technical details

• system: "x86_64-linux"
• host os: Linux 4.4.0-42-generic, Ubuntu, 16.04.4 LTS (Xenial Xerus)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.0
• channels(ck): "nixpkgs-18.03.132013.41b1c57d8dd"
• channels(root): "nixpkgs-17.09.2029.ab36c74390"
• nixpkgs: /home/local/ck/code/nixpkgs

[ckauhaus]

@jluttine

[dotlambda]

That's a known upstream issue: tholo/pytest-flake8#45

[ckauhaus]

ic - would be probably better to patch the offending test out instead of letting the whole package build fail

[jluttine]

This is now fixed upstream in version 1.0.1. I made a pull request for the upgrade: #39815