Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package update required: Datadog-agent #39808

Closed
coretemp opened this issue May 1, 2018 · 3 comments
Closed

package update required: Datadog-agent #39808

coretemp opened this issue May 1, 2018 · 3 comments

Comments

@coretemp
Copy link
Contributor

coretemp commented May 1, 2018

Issue description

Datadog-agent version 5 is packaged in NixOS master.

Version 6 is available here: https://github.com/DataDog/datadog-agent

It's likely useful for both 5 and 6 to remain available.

@tazjin
Copy link
Member

tazjin commented May 24, 2018

Both 5 and 6 should be updated.

There is an unfinished PR for adding v6 in #40399.
Motivation for updating v5 to a newer version is in #40103.


Regarding the update of v5 to a more recent version (latest is 5.24.0, nixpkgs currently has 5.11.2) I've been looking at the build a bit. Building a new derivation by just updating the sources produces an output, but the output does not have the default configuration files at the same locations (or at all) as they previously were.

@domenkozar
Copy link
Member

Same here, diff:

diff --git a/pkgs/tools/networking/dd-agent/default.nix b/pkgs/tools/networking/dd-agent/default.nix
index 1038882573b..79a5bca87e7 100644
--- a/pkgs/tools/networking/dd-agent/default.nix
+++ b/pkgs/tools/networking/dd-agent/default.nix
@@ -28,14 +28,14 @@ let
   };
 
 in stdenv.mkDerivation rec {
-  version = "5.11.2";
+  version = "5.24.0";
   name = "dd-agent-${version}";
 
   src = fetchFromGitHub {
     owner  = "datadog";
     repo   = "dd-agent";
     rev    = version;
-    sha256 = "1iqxvgpsqibqw3vk79158l2pnb6y4pjhjp2d6724lm5rpz4825lx";
+    sha256 = "1a1zysawmzlq88igkmbhn2pk35q396z1snczgy6sddazh2dcp78h";
   };
 
   patches = [ ./40103-iostat-fix.patch ];

@domenkozar
Copy link
Member

Given that we have 6 now in 18.09, closing in favor of #46142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants