Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs.xorg should use newScope #41154

Closed
cleverca22 opened this issue May 27, 2018 · 3 comments
Closed

pkgs.xorg should use newScope #41154

cleverca22 opened this issue May 27, 2018 · 3 comments

Comments

@cleverca22
Copy link
Contributor

Issue description

it is basically imposible to override things like pkgs.xorg.libX11 because things like xorg.libXrandr refer to it within a rec { set

if it was redone like this:

let
  packages = self: {
    libX11 = self.callPackage .... {};
    libXrandr = self.callPackage ... {};
  };
in pkgs.lib.makeScope pkgs.newScope packages

then you can more easily refer to other packages within that set, and it can also support xorg = pkgs.xorg.overrideScope to insert overrides into it

@stale
Copy link

stale bot commented Jun 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
@LunNova
Copy link
Member

LunNova commented Feb 17, 2022

Still an issue, ran into while trying to override xorg.fontbhlucidatypewriter100dpi.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 17, 2022
@Artturin
Copy link
Member

It uses makeScopeWithSplicing' now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants