-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift: fix mkdir command #41274
openshift: fix mkdir command #41274
Conversation
@GrahamcOfBorg build openshift |
@@ -48,7 +48,7 @@ in stdenv.mkDerivation rec { | |||
|
|||
substituteInPlace pkg/oc/bootstrap/docker/host/host.go \ | |||
--replace 'nsenter --mount=/rootfs/proc/1/ns/mnt mkdir' \ | |||
'nsenter --mount=/rootfs/proc/1/ns/mnt ${utillinux}/bin/mount' | |||
'nsenter --mount=/rootfs/proc/1/ns/mnt ${utillinux}/bin/mkdir' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this? mkdir
is part of coreutils
, not utillinux
.
Success on x86_64-linux (full log) Attempted: openshift Partial log (click to expand)
|
@GrahamcOfBorg eval |
Success on aarch64-linux (full log) Attempted: openshift Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: openshift Partial log (click to expand)
|
@GrahamcOfBorg build openshift |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: openshift Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: openshift Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: openshift Partial log (click to expand)
|
Motivation for this change
Wrong command replacement (mount -> mkdir)
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)