Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant module overrides extraComponents when autoExtraComponents is true #43843

Closed
FRidh opened this issue Jul 20, 2018 · 1 comment
Closed

Comments

@FRidh
Copy link
Member

FRidh commented Jul 20, 2018

Issue description

I think this should be clearly mentioned in the manual.

19:30 <etu> Hmm, I have an issue regarding extraComponents in home-assistant. Can someone explain why the second block works but the first doesn't: https://ptpb.pw/31Lu/nix 
19:31 <etu> With the first block I get messages in the log like "python module missing" 
19:31 <etu> But reading the code it should result in the same thing 
19:37 <FRidh> etu: heh the module overrides extraComponents, you need to set autoExtraComponents 
19:38 <FRidh> I suggest opening an issue because this is just mean :) At the very least it would have to be added to the module description 
19:39 <etu> FRidh: Huh? autoExtraComponents? I don't find any option like this 
19:39 <etu> FRidh: ah, in the module 
19:39 <FRidh> etu it's a module option 
19:39 <etu> thanks 
19:41 <etu> FRidh: Well, that's an annoying module behaviour I'd say :D 

cc @dotlambda @peterhoeg

@dotlambda
Copy link
Member

@etu Sorry for that. That's definitely not intended. In #43845, I changed it so that extraComponents is only overridden if config != null.

globin pushed a commit to mayflower/nixpkgs that referenced this issue Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants