Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize ntpd fix for ntp#27 #45885

Closed
samueldr opened this issue Aug 31, 2018 · 3 comments
Closed

Finalize ntpd fix for ntp#27 #45885

samueldr opened this issue Aug 31, 2018 · 3 comments

Comments

@samueldr
Copy link
Member

samueldr commented Aug 31, 2018

[16:54:10] <clever> gchristensen: we will want to make sure ntpd still works on the next nixos release
[16:54:22] <gchristensen> clever: 'h?
[16:54:24] <clever> gchristensen: there is a bug that causes it to half die, but not quit, after a few hours of uptime
[16:54:33] <gchristensen> okay
[16:54:40] <samueldr> clever: is this tracked?
[16:54:44] <clever> pip3000: no ; at the end of the file
[16:55:05] <clever> samueldr: https://github.com/ntp-project/ntp/pull/27
[16:55:07] <{^_^}> ntp-project/ntp#27 (by cleverca22, 11 weeks ago, open): fix the seccomp filter to include a few previously missed syscalls
[16:55:18] <samueldr> (tracked in nixpkgs)
[16:55:40] <clever> i had filed a PR, then it got merged, then i noticed a typo that means i only fixed 32bit ntpd, lol
[16:55:52] <clever> havent gotten around to a 2nd pr or a proper issue
[16:56:17] <clever> https://github.com/quixoftic/nixpkgs-quixoftic/commit/a3db72a697068c6deadc812a05cd58b5e7835862#diff-ba2b2a69f2886f7fc387b30c61ecd706R14

This'll need to be completely fixed.

See:

cc @cleverca22

@samueldr samueldr added this to the 18.09 milestone Aug 31, 2018
@zarelit
Copy link
Member

zarelit commented Oct 27, 2018

Is this related to #38627 ?

zarelit added a commit to zarelit/nixpkgs that referenced this issue Oct 31, 2018
After a series of amendments the seccomp.patch made ntpd work properly
but only on 32-bit systems.
This commit replaces that patch with the one submitted upstream by
cleverca22 and that fixes the issue also on 64-bit systems.

Close NixOS#38627, NixOS#45885
zarelit added a commit to zarelit/nixpkgs that referenced this issue Oct 31, 2018
After a series of amendments the seccomp.patch made ntpd work properly
but only on 32-bit systems.
This commit replaces that patch with the one submitted upstream by
cleverca22 and that fixes the issue also on 64-bit systems.

Close NixOS#38627, NixOS#45885

(cherry picked from commit 6759b79)
@zarelit
Copy link
Member

zarelit commented Nov 5, 2018

@samueldr Does the PR close this issue? It wasn't automatically closed because of a malformed commit message in the PR.

@samueldr
Copy link
Member Author

samueldr commented Nov 6, 2018

I believe so, @cleverca22 (ask to) re-open the issue if it wasn't what the small discussion was about.

Thanks @zarelit.

@samueldr samueldr closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants