-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fwupd: 1.1.2 -> 1.2.1 #48519
fwupd: 1.1.2 -> 1.2.1 #48519
Conversation
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: fwupd Partial log (click to expand)
|
cc #48427 (the PR mentioned above). |
f8847a6
to
9d5f6cb
Compare
Updated, depends on #46020 |
Failure on aarch64-linux (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: fwupd, libxmlb Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
@GrahamcOfBorg build fwupd (not sure if tests pass currently, but let's see...) |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.fwupd Partial log (click to expand)
|
libxmlb 1.1.5 is out, do we want to include it as well? |
Yup. |
Failure on x86_64-linux (full log) Attempted: fwupd Partial log (click to expand)
|
We need to wait for #50876 |
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.fwupd Partial log (click to expand)
|
9d5f6cb
to
d0f41a3
Compare
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
Well FWIW bumping to 0.1.5 (and adding a python3 dependency, apparently) and rebasing onto staging -- produces a bunch of build errors that didn't seem obvious. My internet is being wonky or I'd be linking a branch/commit as well as logs, but anyway just a heads-up I suppose. Oh hey managed to get the logs to gist anyway: https://gist.github.com/dtzWill/6412a806c9993ef01e1b4be4e20c938d |
Failure on x86_64-darwin (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: fwupd, libxmlb Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
83bf364
to
e2c68f2
Compare
Failure on aarch64-linux (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: libxmlb The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: fwupd, libxmlb Partial log (click to expand)
|
@GrahamcOfBorg build fwupd |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: fwupd Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: fwupd Partial log (click to expand)
|
I guess we should squash the commits. |
e2c68f2
to
f773d28
Compare
]; | ||
|
||
LC_ALL = "en_US.UTF-8"; # For po/make-images | ||
|
||
patches = [ | ||
./fix-paths.patch | ||
./add-option-for-installation-sysconfdir.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I brought this patch in tree because, IIRC, the url before wouldn't have been stable.
f773d28
to
24c48d9
Compare
@GrahamcOfBorg test fwupd |
Failed locally for me with
|
Test succeeds locally, and I double checked |
59e6f4c
to
26b16a6
Compare
Something to keep in mind for next update: https://github.com/hughsie/fwupd/pull/865 |
26b16a6
to
28b0c21
Compare
Add cairo dep and others checked for in fwupd's meson.build. Cairo at least is required.
28b0c21
to
1b5de09
Compare
I think everything looks good. Lets go for it 👍 |
Thank you all for working on this and seeing it through!
Very much appreciated :D
…On Thu, 13 Dec 2018 08:51:01 -0800, worldofpeace ***@***.***> wrote:
Merged #48519 into master.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#48519 (comment) part: text/html
|
https://github.com/hughsie/fwupd/blob/1.1.3/NEWS
Upgrade to 1.1.2 broke things but has known fix that should be landing soon--
this bump needs same fix so test appropriately. :)
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)