Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium build cycling on Hydra #49442

Closed
vcunat opened this issue Oct 30, 2018 · 14 comments
Closed

chromium build cycling on Hydra #49442

vcunat opened this issue Oct 30, 2018 · 14 comments

Comments

@vcunat
Copy link
Member

vcunat commented Oct 30, 2018

The chromium builds are now repeatedly "aborted" on Hydra.nixos.org, and it isn't even clear why. The result is huge waste of resources, and blocked channel due to never finishing.

Examples:

I see it happening on two different machines. @edolstra: any idea how to get some logs from the abortions? Otherwise I can't see how to deal with it. Also /cc @grahamc (Packet machines).

My first guess would be that it exhausts some resource, e.g. /tmp/ space.

@vcunat
Copy link
Member Author

vcunat commented Oct 30, 2018

Looking at job lists (e.g. trunk), it always started exactly on 69 -> 70 bump, both on master and 18.09, so we could most likely avoid the problem temporarily by reverting that bump.

@vcunat
Copy link
Member Author

vcunat commented Oct 30, 2018

I now at least manually cancelled most of the jobs, so there aren't too many versions tried at once.

@Synthetica9
Copy link
Member

@vcunat
Copy link
Member Author

vcunat commented Oct 30, 2018

That post seems windows-specific. It's over a year old, and at least at that time I had no such issues when building chromium via nix(os) in background (I haven't tried now yet).

@bendlas
Copy link
Contributor

bendlas commented Oct 30, 2018

Hm, so it started failing before switching to clang, which is simultaneously good and bad news ;-)
Let's hope, it can be resolved as part of NixOS/nix#2493 as Eelco suggested.

Sorry, that I didn't catch this failure. I have now starred
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.chromium.x86_64-linux and enabled notifications on hydra. That should mean, I get notified of such conditions, right?

Unfortunately, the aborted jobs don't seem to have log files available. Do you have any hint as to what caused it to abort? @vcunat
We don't happen to build chromium on a tmpfs, do we?

I'll keep an eye on https://hydra.nixos.org/build/83226757/nixlog/140/tail
If it goes through, can I re-attempt the version bump right away, or should I wait until the channel finishes?

@vcunat
Copy link
Member Author

vcunat commented Oct 31, 2018

No, I found no relevant logs.

@vcunat
Copy link
Member Author

vcunat commented Oct 31, 2018

/tmp(fs): a superficial search in configs suggested that only ike uses it, and that one doesn't have the "big-parallel" feature (so shouldn't get chromium).

@vcunat
Copy link
Member Author

vcunat commented Oct 31, 2018

OK, that build you linked succeeded 🎉 I hope that's it, but we'll see.

@andir
Copy link
Member

andir commented Nov 1, 2018

The build succeeded but the tests are now failing due to changes in the sandbox outputs.

@bendlas Could you have a look at them?

Here is a screenshot of the VM test that fails:

2018-11-01-132444_1452x695_scrot

The logs from 18.09 before the recent systemd bump: https://gist.github.com/andir/2b64a68bb0bf953ebe02102aca358b44 & hydra log for comparison https://nix-cache.s3.amazonaws.com/log/adaq71i6yc400pm392d4hc04xwl9ick1-vm-test-run-chromium-stable.drv

hydra build: https://hydra.nixos.org/build/83250711

@vcunat
Copy link
Member Author

vcunat commented Nov 1, 2018

Related problem I see now: NixOS/hydra#591 (comment)

@domenkozar
Copy link
Member

domenkozar commented Nov 1, 2018

I've pushed 89ede97 in a desperate attempt to fix timeout issues.

vcunat added a commit that referenced this issue Nov 1, 2018
/cc #49442.  It should decrease the waste of resources due to abortions.
aszlig added a commit that referenced this issue Nov 2, 2018
As reported by @andir, the regular expressions that match the sandbox
output are no longer matching in the recent Chromium bump as of
bb03fbc.

Instead of a boolean field that determines whether namespace sandboxes
are on, the namespace sandbox is now an enum within "Layer 1 Sandbox".

I've modified the regular expressions accordingly and also ran the test
for the stable branch, which now succeeds.

Signed-off-by: aszlig <aszlig@nix.build>
Issue: #49442
Cc: @bendlas, @andir
(cherry picked from commit 73cdd5a)
aszlig added a commit that referenced this issue Nov 2, 2018
As reported by @andir, the regular expressions that match the sandbox
output are no longer matching in the recent Chromium bump as of
bb03fbc.

Instead of a boolean field that determines whether namespace sandboxes
are on, the namespace sandbox is now an enum within "Layer 1 Sandbox".

I've modified the regular expressions accordingly and also ran the test
for the stable branch, which now succeeds.

Signed-off-by: aszlig <aszlig@nix.build>
Issue: #49442
Cc: @bendlas, @andir
@vcunat
Copy link
Member Author

vcunat commented Nov 2, 2018

Here's an out-of-space error on packet-t2-4, but those aren't that often.

@vcunat
Copy link
Member Author

vcunat commented Nov 3, 2018

We now had multiple successes of the test and chromium itself, on both branches. Thanks everyone!

@vcunat vcunat closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@domenkozar @bendlas @andir @vcunat @Synthetica9 and others